Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RecursionError: maximum recursion depth exceeded when using new_from_builder() #731

Closed
JRubics opened this issue Jun 22, 2022 · 6 comments · Fixed by #732
Closed

RecursionError: maximum recursion depth exceeded when using new_from_builder() #731

JRubics opened this issue Jun 22, 2022 · 6 comments · Fixed by #732
Labels
bug An existing feature is not working as intended

Comments

@JRubics
Copy link
Contributor

JRubics commented Jun 22, 2022

After fixing this issue, another bug occurs when calling new_from_builder(): RecursionError: maximum recursion depth exceeded

Since the previous issue was hard to reproduce, I created a small example where you can check it: https://github.com/JRubics/masonite-orm-issue-example

Steps to run it are in the README.md.
Be sure to test it with both masonite-orm 2.13.2 (old issue) and 2.13.3 (new issue)

Desktop:

OS: Linux
Version Ubuntu 21.10

What database are you using?

Type: [MySQL]
Version [14.14 Distrib 5.7.30, for Linux (x86_64) using EditLine wrapper]
Masonite ORM [2.4.2]
@JRubics JRubics added the bug An existing feature is not working as intended label Jun 22, 2022
@josephmancuso
Copy link
Member

Thank you so much for building that repo. Looks like the issue was that you can't deep copy lambda expressions I guess. I changed the deep copies to shallow copies and it fixes this issue but now I need to verify it still fixes the last issue

@JRubics
Copy link
Contributor Author

JRubics commented Jun 27, 2022

Unfortunately, it doesn't fix the previous issue. 😢

@josephmancuso
Copy link
Member

@JRubics which issue?

@JRubics
Copy link
Contributor Author

JRubics commented Jun 27, 2022

#682

@josephmancuso
Copy link
Member

hmm ok ill reopen that issue and take a look

@JRubics
Copy link
Contributor Author

JRubics commented Jun 27, 2022

Thank you :) you can use the same example from this issue to reproduce it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An existing feature is not working as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants