fixed modify change on mysql

MasoniteFramework · Feb 5, 2021 · da71d48 · da71d48
1 parent c70129f
commit da71d48
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/masoniteorm/schema/platforms/MySQLPlatform.py b/src/masoniteorm/schema/platforms/MySQLPlatform.py
@@ -176,12 +176,12 @@ def compile_alter_sql(self, table):
             )
 
         if table.changed_columns:
-
             sql.append(
                 self.alter_format().format(
                     table=self.wrap_table(table.name),
-                    columns="MODIFY "
-                    + ", ".join(self.columnize(table.changed_columns)),
+                    columns=", ".join(
+                        f"MODIFY {x}" for x in self.columnize(table.changed_columns)
+                    ),
                 )
             )
 

diff --git a/tests/mysql/schema/test_mysql_schema_builder_alter.py b/tests/mysql/schema/test_mysql_schema_builder_alter.py
@@ -141,18 +141,19 @@ def test_alter_drop_unique_constraint_shortcut(self):
     def test_change(self):
         with self.schema.table("users") as blueprint:
             blueprint.integer("age").change()
+            blueprint.integer("gender").nullable().change()
             blueprint.string("name")
 
         self.assertEqual(len(blueprint.table.added_columns), 1)
-        self.assertEqual(len(blueprint.table.changed_columns), 1)
+        self.assertEqual(len(blueprint.table.changed_columns), 2)
         table = Table("users")
         table.add_column("age", "string")
 
         blueprint.table.from_table = table
 
         sql = [
             "ALTER TABLE `users` ADD `name` VARCHAR(255) NOT NULL",
-            "ALTER TABLE `users` MODIFY `age` INT(11) NOT NULL",
+            "ALTER TABLE `users` MODIFY `age` INT(11) NOT NULL, MODIFY `gender` INT(11) NULL",
         ]
 
         self.assertEqual(blueprint.to_sql(), sql)