Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement Trait? #214

Open
droundy opened this issue Nov 11, 2018 · 2 comments
Open

implement Trait? #214

droundy opened this issue Nov 11, 2018 · 2 comments

Comments

@droundy
Copy link

droundy commented Nov 11, 2018

Now that implement Trait is stable, could you use it both for code and examples in order to simplify the API?

@Marwes
Copy link
Owner

Marwes commented Nov 15, 2018

There are some examples that uses impl Trait but I have held of using it in the library itself to enable combine to be used on older compilers.

Thanks to https://docs.rs/combine/3.6.2/combine/macro.parser.html I don't see a large win in readability from updating to impl Trait so weighing the pros and cons I rather stick with supporting older rustc's for the time being.

@Marwes
Copy link
Owner

Marwes commented Mar 14, 2019

Unfortunately issues such as rust-lang/rust#42940 causes rustc to error in some cases where it shouldn't so this might not be possible to fix in 4.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants