Skip to content

Conversation

@ellensp
Copy link
Contributor

@ellensp ellensp commented May 25, 2020

Requirements

Use a LPC1768/9 based board.

Description

Attempt to compile Marlin.
It will fail to compile with 'strcmp_P' was not declared
This is missing from LP1768/9 arduino framework.

Benefits

Adds strcmp_P and marlin compiles.

Related Issues

#18102
#18001
0578bbb

@ellensp
Copy link
Contributor Author

ellensp commented May 25, 2020

Also missing from Linux framework from the CI / test_builds (linux_native) error

@thinkyhead thinkyhead added PR: Bug Fix T: HAL & APIs Topic related to the HAL and internal APIs. labels May 25, 2020
@thinkyhead thinkyhead merged commit 9bfdc88 into MarlinFirmware:bugfix-2.0.x May 25, 2020
@thinkyhead thinkyhead changed the title fix 18102. Add strcmp_P to LCP1768/9 Supply strcmp_P where needed May 25, 2020
vgadreau pushed a commit to vgadreau/Marlin that referenced this pull request May 29, 2020
jmp0x0000 pushed a commit to jmp0x0000/Marlin that referenced this pull request Aug 7, 2020
HairingX pushed a commit to HairingX/Marlin that referenced this pull request Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Bug Fix T: HAL & APIs Topic related to the HAL and internal APIs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants