fix cpuinfo branch #214
Merged
fix cpuinfo branch #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maratyszcza
requested changes
Jan 31, 2023
CMakeLists.txt
Outdated
| IF(${CMAKE_VERSION} VERSION_LESS "3.1") | ||
| IF(NOT MSVC) | ||
| TARGET_COMPILE_OPTIONS(${target} PRIVATE -std=gnu++11) | ||
| TARGET_COMPILE_OPTIONS(${target} PRIVATE -std=gnu++11 -fPIC) |
Owner
There was a problem hiding this comment.
This is unrelated, please revert
Contributor
Author
There was a problem hiding this comment.
I have fixed it.
delete -fPIC
Liam-Sturge
added a commit
to Liam-Sturge/tvm
that referenced
this pull request
Feb 3, 2023
This patch undoes the change that was put in place to prevent the build and installation of NNPACK from failing due to a renaming of the default branch to main by the NNPACK external dependency cpuinfo. See apache#13871 The issue has been fixed at the source by PR apache#214, so the change to `ubuntu_install_nnpack.sh` is no longer required: Maratyszcza/NNPACK#214
driazati
pushed a commit
to apache/tvm
that referenced
this pull request
Feb 7, 2023
This patch undoes the change that was put in place to prevent the build and installation of NNPACK from failing due to a renaming of the default branch to main by the NNPACK external dependency cpuinfo. See #13871 The issue has been fixed at the source by PR #214 which is now merged in to NNPACK, so the change to `ubuntu_install_nnpack.sh` is no longer required: Maratyszcza/NNPACK#214
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.