Make map-properties popup size dynamic #1017
Conversation
| const map = layer._map; | ||
| const popupOptions = { | ||
| autoClose: false, | ||
| autoPan: true, |
There was a problem hiding this comment.
I believe the autoPan value was the default false and that was intentional so that the map wouldn't keep panning and pulling in new features, which might be a problem for a screenreader user (?). That was my theory anyhow. I guess we can keep this value and see if it engenders any comment from anyone else though.
| projection: map.options.projection, | ||
| mapEl: this._linkEl.getMapEl(), | ||
| onEachFeature: function (properties, geometry) { | ||
| const popupOptions = { |
There was a problem hiding this comment.
I believe the autoPan value was the default false and that was intentional so that the map wouldn't keep panning and pulling in new features, which might be a problem for a screenreader user (?). That was my theory anyhow. I guess we can keep this value and see if it engenders any comment from anyone else though.
prushforth
left a comment
prushforth
left a comment
There was a problem hiding this comment.
Good work! Merge when ready. Thanks!
2 participants
Fixes #893