Adjusted to pass failing tests

Author: yushan-mu

src/map-properties.js

@@ -9,9 +9,9 @@ export class HTMLPropertiesElement extends HTMLElement {
     super();
   }
   connectedCallback() {
-    this._popupDiv = document.createElement('div');
-    this._popupDiv.classList.add('mapml-popup-content');
-    this._popupDiv.insertAdjacentHTML('afterbegin', properties.innerHTML);
+    // this._popupDiv = document.createElement('div');
+    // this._popupDiv.classList.add('mapml-popup-content');
+    // this._popupDiv.insertAdjacentHTML('afterbegin', properties.innerHTML);
   }
   test() {
     console.log('test');

src/mapml-viewer.js

@@ -210,6 +210,7 @@ export class HTMLMapmlViewerElement extends HTMLElement {
         this._changeHeight(h);
 
         this._createMap();
+        this._setPopupHeight();
 
         // https://github.com/Maps4HTML/MapML.js/issues/274
         this.setAttribute('role', 'application');
@@ -330,7 +331,6 @@ export class HTMLMapmlViewerElement extends HTMLElement {
       this._createControls();
       this._toggleControls();
       this._crosshair = crosshair().addTo(this._map);
-      this._setPopupHeight();
 
       if (M.options.featureIndexOverlayOption)
         this._featureIndexOverlay = featureIndexOverlay().addTo(this._map);
@@ -670,7 +670,7 @@ export class HTMLMapmlViewerElement extends HTMLElement {
       const rootHeight = this._container.offsetHeight;
       // Set popup content height as a percentage of root height
       this._popupHeight = `${rootHeight * 0.5}px`; // Adjust 0.8 to the desired ratio
-      popupContentDiv.style.overflowY = 'auto'; // Add scrolling if content overflows
+      // popupContentDiv.style.overflowY = 'auto'; // Add scrolling if content overflows
     }
   }
   _setUpEvents() {

test/e2e/layers/queryLink.test.js

@@ -108,7 +108,7 @@ test.describe('Playwright Query Link Tests', () => {
         (iframe) => iframe.contentWindow.document.querySelector('h1').innerText
       );
       const href = await page.$eval(
-        'div > div.leaflet-pane.leaflet-map-pane > div.leaflet-pane.leaflet-popup-pane > div > div.leaflet-popup-content-wrapper > div > div > a.mapml-zoom-link',
+        'div > div.leaflet-pane.leaflet-map-pane > div.leaflet-pane.leaflet-popup-pane > div > div.leaflet-popup-content-wrapper > div > a.mapml-zoom-link',
         (link) => link.getAttribute('href')
       );
 
@@ -141,7 +141,7 @@ test.describe('Playwright Query Link Tests', () => {
         (iframe) => iframe.contentWindow.document.querySelector('h1').innerText
       );
       const href = await page.$eval(
-        'div > div.leaflet-pane.leaflet-map-pane > div.leaflet-pane.leaflet-popup-pane > div > div.leaflet-popup-content-wrapper > div > div > a.mapml-zoom-link',
+        'div > div.leaflet-pane.leaflet-map-pane > div.leaflet-pane.leaflet-popup-pane > div > div.leaflet-popup-content-wrapper > div > a.mapml-zoom-link',
         (link) => link.getAttribute('href')
       );
 
@@ -176,7 +176,7 @@ test.describe('Playwright Query Link Tests', () => {
         (iframe) => iframe.contentWindow.document.querySelector('h1').innerText
       );
       const href = await page.$eval(
-        'div > div.leaflet-pane.leaflet-map-pane > div.leaflet-pane.leaflet-popup-pane > div > div.leaflet-popup-content-wrapper > div > div > a.mapml-zoom-link',
+        'div > div.leaflet-pane.leaflet-map-pane > div.leaflet-pane.leaflet-popup-pane > div > div.leaflet-popup-content-wrapper > div > a.mapml-zoom-link',
         (link) => link.getAttribute('href')
       );
 
@@ -254,7 +254,7 @@ test.describe('Playwright Query Link Tests', () => {
         (iframe) => iframe.contentWindow.document.querySelector('h1').innerText
       );
       const link = await page.$eval(
-        'div > div.leaflet-pane.leaflet-map-pane > div.leaflet-pane.leaflet-popup-pane > div > div.leaflet-popup-content-wrapper > div > div',
+        'div > div.leaflet-pane.leaflet-map-pane > div.leaflet-pane.leaflet-popup-pane > div > div.leaflet-popup-content-wrapper > div',
         (popup) => popup.querySelector('a.mapml-zoom-link')
       );