Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Requests] Add option for titlebars to use system colour and add the text glow to the native unthemed UI #86

Closed
TheInsane101 opened this issue Feb 3, 2024 · 18 comments
Labels
enhancement New feature or request Processed The issue has been resolved and is awaiting confirmation.

Comments

@TheInsane101
Copy link

The program would be even better than it already is if there was an option for the elements to use the chosen system colour that the rest of the UI uses, so that I don't have to change DWMBG's colour settings every time I change the OS's colours, which is tedious. Is this possible?

Also, it would be nice to have the text glow effect as an option for those who don't use msstyle themes, because without it, the text can be illegible when hovering over a part of a background with the same colour as the text.

These would be great additions, but ofc I udnerstand if it's not possible or too hard. I can wait! Thank you for giving us this program at all!

@Maplespe
Copy link
Owner

Maplespe commented Feb 4, 2024

As I explained, system colors are opaque and there is no light/dark mode distinction, if you use system colors it will be boring opaque solid colors.
As for text glowing, this is not an official feature of this software, as I explained in #75, it depends on the 3rd party theme, if the 3rd party theme supports text glowing, we will draw it, if not, we can't draw it.
So we won't consider doing extra work at the moment, we've been doing too much work lately.

@ALTaleX531 ALTaleX531 added the enhancement New feature or request label Feb 4, 2024
@funn-hue
Copy link

funn-hue commented Feb 4, 2024

The program would be even better than it already is if there was an option for the elements to use the chosen system colour that the rest of the UI uses, so that I don't have to change DWMBG's colour settings every time I change the OS's colours, which is tedious. Is this possible?

Also, it would be nice to have the text glow effect as an option for those who don't use msstyle themes, because without it, the text can be illegible when hovering over a part of a background with the same colour as the text.

These would be great additions, but ofc I udnerstand if it's not possible or too hard. I can wait! Thank you for giving us this program at all!

you can always modify stock 10 theme with like msstyle editor and add glow yourself

@DanTheGuy720
Copy link

As I explained, system colors are opaque and there is no light/dark mode distinction, if you use system colors it will be boring opaque solid colors. As for text glowing, this is not an official feature of this software, as I explained in #75, it depends on the 3rd party theme, if the 3rd party theme supports text glowing, we will draw it, if not, we can't draw it. So we won't consider doing extra work at the moment, we've been doing too much work lately.

Is there no way to programmatically grab the current system personalization color values from the registry or something and just copy it into DWMBlurGlass config? That way, it's still using the application's coloring system over Windows. Though I suppose that would require CONSTANTLY checking the registry... unless you just did it once at initial logon or something.

@TheInsane101
Copy link
Author

TheInsane101 commented Feb 4, 2024

As I explained, system colors are opaque and there is no light/dark mode distinction, if you use system colors it will be boring opaque solid colors.

I don't mind resetting the opacity every time. In fact, it is better to reset the opacity than it is to constantly update the colours. Firstly, I usually have one opacity value that I always keep the same no matter which colours I choose. However, with colours, I have to open the RGB settings in DWMBG and match the values with those in the Startisback properties window, since I've set that to use the system colours every time I change them. This takes much more time to do.

Also, I don't understand how the system colours would make everything opaque. In Startisback, you can set the taskbar and start menu to use the same blur that DWMBG uses, and when the program uses the system colour, it doesn't become opaque. Is it different for the titlebars etc?

2024-02-04.11-26-49.-.Trim.mp4

@AquaHarp
Copy link

AquaHarp commented Feb 4, 2024

if you use system colors it will be boring opaque solid colors.

https://superuser.com/questions/1245923/registry-keys-to-change-personalization-settings
通过软件的GUI手动设置不透明度,只从注册表中读取RGB颜色值(在HKEY_CURRENT_USER\Software\Microsoft\Windows\DWMAccentColor这一项,数据格式是ABGR,Alpha值总是FF),保持已经设置的不透明度不变。
就算想跟随主题的变换而改变不透明度,这个数据在HKEY_CURRENT_USER\Software\Microsoft\Windows\DWMColorizationColor这一项,数据格式是ARGB。而且主题文件(例如aero.theme文件)里也有ColorizationColor这一项,数据格式是ARGB,而A的值对应着win7个性化设置的"颜色浓度"。可以给几个选项让用户决定是否让颜色或不透明度设置跟随系统注册表变化。

Set opacity values through DWMBlurGlass GUI.
Read RGB values from Registry and ignore opacity values, I think.

image

image

@NotJorrd
Copy link

NotJorrd commented Feb 4, 2024

it's something glass8 does, which is why i guess i think it might be possible, i get that this isn't glass8 but it would be a cool feature to see, especially for people with these themes such as myself:

image

this so far, is my only setback from a near perfect 7 theme

@NotJorrd
Copy link

NotJorrd commented Feb 4, 2024

As I explained, system colors are opaque and there is no light/dark mode distinction, if you use system colors it will be boring opaque solid colors.

I don't mind resetting the opacity every time. In fact, it is better to reset the opacity than it is to constantly update the colours. Firstly, I usually have one opacity value that I always keep the same no matter which colours I choose. However, with colours, I have to open the RGB settings in DWMBG and match the values with those in the Startisback properties window, since I've set that to use the system colours every time I change them. This takes much more time to do.

Also, I don't understand how the system colours would make everything opaque. In Startisback, you can set the taskbar and start menu to use the same blur that DWMBG uses, and when the program uses the system colour, it doesn't become opaque. Is it different for the titlebars etc?
2024-02-04.11-26-49.-.Trim.mp4

my startisback doesn't change to my system colors, is there a way you made it adapt?

@ALTaleX531
Copy link
Collaborator

Actually we know how to read the color of the theme color, but can you tell me how to properly handle active/inactive window colors in light/dark mode? After all there is only one theme color, do they all have to use the same color? 😕
The availability of more configurations means that more effort is spent, and we'd like to spend our time implementing more valuable features such as custom blur methods. So I personally don't feel that this is a feature that should be prioritized for implementation, unless you guys can tell me more specifically why you're changing theme colors so often... 🤔

@NotJorrd
Copy link

NotJorrd commented Feb 4, 2024

Actually we know how to read the color of the theme color, but can you tell me how to properly handle active/inactive window colors in light/dark mode? After all there is only one theme color, do they all have to use the same color? 😕 The availability of more configurations means that more effort is spent, and we'd like to spend our time implementing more valuable features such as custom blur methods. So I personally don't feel that this is a feature that should be prioritized for implementation, unless you guys can tell me more specifically why you're changing theme colors so often... 🤔

i get where you're coming from about focusing on custom blur and such, but this could make a big difference if you think about it, not only would you be staying consistent with windows, but you'd be making our lives a lot easier and giving people that extra touch of customization

a lot of people use this software to recreate the look and feel of windows 7, and being able to change our theme in control panel to one of these, while having the color adapt accordingly would be awesome
image

i think i speak for a lot of people when i say i can't pick just one wallpaper, or theme. as a former glass8 user i loved having the option to adapt to the system accent, especially since you can make your accent color change based off of each wallpaper in windows settings, giving you even more customization

thank you for hearing us out

@TheInsane101
Copy link
Author

TheInsane101 commented Feb 4, 2024

Perfectly said @NotJorrd.

@ALTaleX531 The ability to change the colour instantly is one of the charms of the Aero style of Vista and 7. Bringing that back would add to the immersion.

Also, I'm one of those people who can never make up their mind on a theme. I'm constantly changing mine all the time and experimenting with the infinite combinations between backgrounds and colours. Also, I have multiple Aero-based themes installed, including multiple Longhorn versions, Vista and 7, and their beta counterparts, all together, so being able to explore all of them is part of the fun!

I appreciate your ambition to work on the blur options! Sounds like amazing and extremely powerful stuff! You do what you want with your priorities. I just hope this request can still fit in the list, at least AFTER the blur update is done? I hope I wasn't too pushy; don't feel pressured or demotivated by me; I respect your choices!

@TheInsane101
Copy link
Author

TheInsane101 commented Feb 4, 2024

my startisback doesn't change to my system colors, is there a way you made it adapt?

I'm sorry, I don't know what the issue might be. Maybe a SIB bug?

@NotJorrd
Copy link

NotJorrd commented Feb 4, 2024

my startisback doesn't change to my system colors, is there a way you made it adapt?

I'm sorry, I don't know what the issue might be. Maybe a SIB bug?

curious, what version are you using?

@TheInsane101
Copy link
Author

curious, what version are you using?

version 2.9.19. Idk if it's the latest.

A workaround I used when I had the bug (I don't know how it got fixed) was to turn the "use custom colouring" options on and off, but then the opacity resets and you have to readjust it to how you had set it before.

@NotJorrd
Copy link

NotJorrd commented Feb 7, 2024

curious, what version are you using?

version 2.9.19. Idk if it's the latest.

A workaround I used when I had the bug (I don't know how it got fixed) was to turn the "use custom colouring" options on and off, but then the opacity resets and you have to readjust it to how you had set it before.

the issue was a setting in windows, fixed it

@Bungeetaco
Copy link

I second this request, and would like to see this implemented.

@TorutheRedFox
Copy link

the difference between active and inactive colors in aero afaik is that the inactive color is the same as the active color, just has the alpha multiplied by 0.4

@Olive6841
Copy link

the difference between active and inactive colors in aero afaik is that the inactive color is the same as the active color, just has the alpha multiplied by 0.4

Oh really?
Interesting

@TheInsane101
Copy link
Author

curious, what version are you using?

version 2.9.19. Idk if it's the latest.
A workaround I used when I had the bug (I don't know how it got fixed) was to turn the "use custom colouring" options on and off, but then the opacity resets and you have to readjust it to how you had set it before.

the issue was a setting in windows, fixed it

For some reason my SIB no longer adapts the colour anymore; could you please tell me how you fixed it?

@Maplespe Maplespe added the Processed The issue has been resolved and is awaiting confirmation. label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Processed The issue has been resolved and is awaiting confirmation.
Projects
None yet
Development

No branches or pull requests

10 participants