Skip to content

Storypin pop-up remains visible across multiple chapters #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jonpmarino opened this issue Feb 6, 2017 · 3 comments
Closed

Storypin pop-up remains visible across multiple chapters #435

jonpmarino opened this issue Feb 6, 2017 · 3 comments
Assignees

Comments

@jonpmarino
Copy link
Member

jonpmarino commented Feb 6, 2017

cross checked with Darin and Rey on Feb 6.

Desired behavior:
A user should be able to set a storypin start and end time in composer. The desired behavior is that the pin shows up at start time and disappears at end time.

Current problem:

The actual "pin" aspect of the StoryPin is respecting the start and end time, but the pop-up does not (when set to "show content automatically). It remains visible after the end time has passed, and even remains going into the next chapter if the story has multiple chapters.

In this screenshot (showing https://mapstory.org/story/23751) a StoryPin with start time 859 and ending in 1190 is there. Content starts showing automatically at 859 and remains. At 1190 the dot for the pin disappears as expected, but the pop up remains.

screen shot 2017-02-06 at 12 16 27 pm

And it remains even if the story is advanced to Chapter 2.

screen shot 2017-02-06 at 12 35 03 pm

Example uses Chrome Version 55.0.2883.95 (64-bit).

@trepagnier
Copy link
Contributor

Merged here:
#456
MapStory/story-tools#255

@jonpmarino
Copy link
Member Author

re-opening. Pins still show up in the wrong chapters.

@Coop56
Copy link
Contributor

Coop56 commented Dec 3, 2018

This was resolved in a previous sprint.

@Coop56 Coop56 closed this as completed Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants