-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HoloEverywhere #4
Comments
Thanks! Your activity must indeed derive from SherlockActivity, otherwise how will you implement a backwards-compatible action bar? |
Hello, As you can see on HoloEverywhere basic migration guide (https://github.com/Prototik/HoloEverywhere/wiki/Basic-migration-on-HoloEverywhere), while using the library, we always extend our activities from ¨org.holoeverywhere.app.***Activity¨ and the library takes care of compatibility issues with ActionBarSherlock. Thnks |
I see. Let me think of something, I'll get back to you. |
I've just pushed a fix to your problem to the "dev" branch. With this fix the library will work with any activity that implements a method called "getSupportActionBar", regardless of whether it derives from any of the ABS activities. Please test it and tell me if it works for you, before I integrate it with the master branch. |
Hello,
I would like to use it with HoloEverywhere library (https://github.com/Prototik/HoloEverywhere). When trying to use it, the library send me an error message saying that my activity should be an instance of SherlockActivity (and it is the HoloEverywhere activity...).
Thnks and congrats for yout great work!!
The text was updated successfully, but these errors were encountered: