Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove strip operation in CI #325

Closed
Dengjianping opened this issue Jan 5, 2022 · 2 comments · Fixed by #449
Closed

Remove strip operation in CI #325

Dengjianping opened this issue Jan 5, 2022 · 2 comments · Fixed by #449
Assignees
@Dengjianping
Milestone
v3.2.1

Comments

@Dengjianping
Copy link
Contributor

We can remove strip command in CI due to this pr stablized: rust-lang/cargo#10088
But not sure rust 1.58 will include this feature.
@Dengjianping
Copy link
Contributor Author

Dengjianping commented Jan 5, 2022 •
edited
Loading

It will happen to 1.59.
https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-1580-2022-01-13

@Dengjianping
Copy link
Contributor Author

Dengjianping commented Feb 15, 2022 •
edited
Loading

It will happen in 1.59.
This flag can be only used as rustc flag, not available in cargo.profile.

[profile.release]
codegen-units = 1
lto = true
opt-level = 3
panic = "unwind"
strip = "symbols"

@Dengjianping Dengjianping mentioned this issue Mar 16, 2022
Merged
10 tasks
@Garandor Garandor added this to the v3.2.1 milestone Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dengjianping Dengjianping

Labels
None yet
Projects
None yet
Milestone
v3.2.1
Development

Successfully merging a pull request may close this issue.

[manta]Add strip profile to production Manta-Network/Manta
2 participants
@Dengjianping @Garandor