Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically add dependencies for when rules #42

Open
sebasmannem opened this issue Jul 17, 2022 · 0 comments
Open

Automatically add dependencies for when rules #42

sebasmannem opened this issue Jul 17, 2022 · 0 comments

Comments

@sebasmannem
Copy link
Contributor

Steps can have one or more when rules that check if this step should be run depending on outcome of other steps.
The outcome of the other steps can only be verified if the other steps have completed, so a dependency should exist as well.
But we currently don't automatically add steps that are referenced in when rules as dependencies, they need to be added manually.

This could bring unexpected behavior where when rules (like Rc=0) check succesful while the step is still running and might end up unsuccesful later on.

We should build a list of steps being referenced from when rules, and verify if they are added as dependency.
If they are not we should issue a warning and automatically add them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant