Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better caching strategy #79

Open
3 tasks
Manishearth opened this issue Sep 10, 2014 · 3 comments
Open
3 tasks

Better caching strategy #79

Manishearth opened this issue Sep 10, 2014 · 3 comments

Comments

@Manishearth
Copy link
Owner

We currently cache messages in client https://github.com/Manishearth/ChatExchange/blob/master/chatexchange/client.py#L71

However, these are not updated on edits, and it's cached indefinitely. We should have:

  • A way to keep these up to date, perhaps by pinging the message object with new values on edits/stars
  • A way to clean the cache
  • A way to disable the cache
@bjb568
Copy link

bjb568 commented Apr 8, 2015

@Unihedro
Copy link
Contributor

Unihedro commented Apr 9, 2015

+1 for cache control.

@danbopes
Copy link

Can I ask how the caching currently works?

From what I can see, you're creating a new instance, adding it to the cache, and returning it. At no point are you actually reading from the cache and returning that data. On new message creation, if that message ID exists in this queue, it's not being fetched, nor utilized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants