Skip to content

Conversation

@jeffbonson
Copy link
Contributor

@jeffbonson jeffbonson commented Jun 14, 2024

Note:

Before

  • HAML list was used for child services summary.
  • image
  • Click event on the child services will return an error.
[----] I, [2024-06-14T10:42:00.965059 #38561:60784]  INFO -- : Started POST "/service/tree_select/?id=s-132" for ::1 at 2024-06-14 10:42:00 +0530
[----] F, [2024-06-14T10:42:01.109760 #38561:60784] FATAL -- :   
ActionController::RoutingError (No route matches [POST] "/service/tree_select"):
 

After

  • Converted the child service summary from HAML to React.
  • Click on the child service row will redirect the page to the corresponding service summary page.
  • Screenshot 2024-06-14 at 10 36 30 AM
    image

@miq-bot
Copy link
Member

miq-bot commented Jun 14, 2024

Checked commit jeffbonson@5e32298 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. 🍰

@Fryguy
Copy link
Member

Fryguy commented Jun 26, 2024

Backported to radjabov in commit f6178ac.

commit f6178ac4549d0215ce7b0a4c8be67a6882101648
Author: Gilbert Cherrie <[email protected]>
Date:   Thu Jun 20 15:30:15 2024 -0400

    Merge pull request #9207 from jeffbonson/fix-child-services-link
    
    Fix child services link
    
    (cherry picked from commit 8adaffa3e56b87b0ea007f7f76eb1e7e5d717d76)

Fryguy pushed a commit that referenced this pull request Jun 26, 2024
Fix child services link

(cherry picked from commit 8adaffa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants