Skip to content

host initiator creation: bug in the group/cluster field #8812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
agrare merged 1 commit into from
Jun 14, 2023
Merged

host initiator creation: bug in the group/cluster field #8812

agrare merged 1 commit into from
Jun 14, 2023

Conversation

@OrGur1987
Copy link
Contributor

@OrGur1987 OrGur1987 commented Jun 4, 2023 •
edited by agrare
Loading

the isSearchable prop in the host group field caused a bug:

image

removing this prop required to also change the value sent by the form, so that it will send the group name and not its id. an adjustment was made in the provider code as well:

@OrGur1987 OrGur1987 requested a review from a team as a code owner June 4, 2023 10:17
@OrGur1987 OrGur1987 changed the title fixed bugs in host-initiator-form.schema.js (ui) and in `HostInitia… fixed bugs in host group selection in host creation form Jun 4, 2023
@OrGur1987 OrGur1987 mentioned this pull request Jun 4, 2023
Merged
1 task
@miq-bot
Copy link
Member

miq-bot commented Jun 4, 2023

Checked commit Autosde@2ef37a7 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@OrGur1987 OrGur1987 changed the title fixed bugs in host group selection in host creation form host initiator creation: bug in the group/cluster field Jun 4, 2023
@jeffibm jeffibm added the bug label Jun 5, 2023
@agrare agrare closed this Jun 14, 2023
@agrare agrare reopened this Jun 14, 2023
@agrare agrare merged commit bacd478 into ManageIQ:master Jun 14, 2023
@agrare
Copy link
Member

agrare commented Jun 14, 2023

@OrGur1987 does this have to be backported? (Is this bug present in petrosian)

@OrGur1987
Copy link
Contributor Author

OrGur1987 commented Jun 14, 2023

@OrGur1987 does this have to be backported? (Is this bug present in petrosian)

I think so, how can I check?

@agrare
Copy link
Member

agrare commented Jun 14, 2023

You would use git to see if whatever commit introduced the bug is in that branch

@OrGur1987
Copy link
Contributor Author

OrGur1987 commented Jun 15, 2023

thanks
previous revision was 29a3820 from March and it's in petrosian:

$ manageiq-ui-classic % git checkout petrosian                                        
Switched to branch 'petrosian'
Your branch is up to date with 'origin/petrosian'.
$ manageiq-ui-classic % git branch --contains 29a38203c63743c262357cc79327028fd5ec39b6
  master
* petrosian

@Fryguy
Copy link
Member

Fryguy commented Jun 28, 2023

Backported to petrosian in commit d55644d.

commit d55644d609a415e874a79de9bdb3cd08922d3abd
Author: Adam Grare <[email protected]>
Date:   Wed Jun 14 09:51:28 2023 -0400

    Merge pull request #8812 from Autosde/host_initiator_form-group_selection_bug
    
    host initiator creation: bug in the group/cluster field
    
    (cherry picked from commit bacd47816a6313072f5b66ae30a857e3f65499fd)

Fryguy pushed a commit that referenced this pull request Jun 28, 2023
@agrare @Fryguy
Merge pull request #8812 from Autosde/host_initiator_form-group_selec…
d55644d 
…tion_bug

host initiator creation: bug in the group/cluster field

(cherry picked from commit bacd478)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jeffibm jeffibm jeffibm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jeffibm jeffibm

Labels

bug petrosian/backported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@OrGur1987 @miq-bot @agrare @Fryguy @jeffibm