Move prov_field_changed test into own describe

Author: agrare

spec/controllers/application_controller/miq_request_methods_spec.rb

@@ -30,28 +30,39 @@
       partial = controller.send(:dialog_partial_for_workflow)
       expect(partial).to eq('prov_configured_system_foreman_dialog')
     end
+  end
+
+  describe '#prov_field_changed' do
+    before { stub_user(:features => %w[miq_request_edit]) }
+
+    context "with an InfraManager provision workflow" do
+      let(:wf)         { FactoryBot.create(:miq_provision_virt_workflow) }
+      let(:ems)        { FactoryBot.create(:ems_infra) }
+      let(:datacenter) { FactoryBot.create(:datacenter,     :ext_management_system => ems, :name => 'dcname') }
+      let(:ems_folder) { FactoryBot.create(:ems_folder,     :ext_management_system => ems) }
+      let(:vm2)        { FactoryBot.create(:vm_infra,       :ext_management_system => ems) }
+      let(:template)   { FactoryBot.create(:template_infra, :ext_management_system => ems) }
+
+      it "clears the request datacenter name field when the source VM is changed" do
+        wf.instance_variable_set(:@dialogs, :dialogs => {:environment => {:fields => {:placement_dc_name => {:values => {datacenter.id.to_s => datacenter.name}}}}})
+
+        controller.instance_variable_set(:@edit, :wf => wf, :new => {:src_vm_id => template.id.to_s})
+        controller.instance_variable_set(:@last_vm_id, vm2.id)
+        controller.params = {'service__src_vm_id' => template.id, :id => "new", :controller => "miq_request"}
+        wf.instance_variable_set(:@values, :placement_dc_name=>[datacenter.id.to_s, datacenter.name])
 
-    it "clears the request datacenter name field when the source VM is changed" do
-      datacenter = FactoryBot.create(:datacenter, :name => 'dcname')
-      ems_folder = FactoryBot.create(:ems_folder)
-      ems = FactoryBot.create(:ems_vmware)
-      template = FactoryBot.create(:template_vmware)
-      vm2 = FactoryBot.create(:vm_vmware)
-      datacenter.ext_management_system = ems
-      ems_folder.ext_management_system = ems
-      @wf.instance_variable_set(:@dialogs, :dialogs => {:environment => {:fields => {:placement_dc_name => {:values => {datacenter.id.to_s => datacenter.name}}}}})
-      controller.instance_variable_set(:@edit, :wf => @wf, :new => {:src_vm_id => template.id.to_s})
-      controller.instance_variable_set(:@last_vm_id, vm2.id)
-      controller.params = {'service__src_vm_id' => template.id, :id => "new", :controller => "miq_request"}
-      @wf.instance_variable_set(:@values, :placement_dc_name=>[datacenter.id.to_s, datacenter.name])
-      edit = {:wf => @wf, :new => {:placement_dc_name => [datacenter.id, datacenter.name]}}
-      @wf.instance_variable_set(:@edit, edit)
-      allow(controller).to receive(:load_edit).and_return(true)
-      allow(controller).to receive(:render).and_return(true)
-      allow(@wf).to receive(:get_field).and_return(:values => {:placement_dc_name=>[datacenter.id.to_s, datacenter.name]})
-      controller.send(:prov_field_changed)
-      values = @wf.instance_variable_get(:@values)
-      expect(values.to_s).to_not include('dcname')
+        edit = {:wf => wf, :new => {:placement_dc_name => [datacenter.id, datacenter.name]}}
+        wf.instance_variable_set(:@edit, edit)
+
+        allow(controller).to receive(:load_edit).and_return(true)
+        allow(controller).to receive(:render).and_return(true)
+        allow(wf).to receive(:get_field).and_return(:values => {:placement_dc_name=>[datacenter.id.to_s, datacenter.name]})
+
+        controller.send(:prov_field_changed)
+
+        values = wf.instance_variable_get(:@values)
+        expect(values.to_s).to_not include('dcname')
+      end
     end
   end