Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolution KW not working properly on OSX with retina GLMakie.jl #766

Closed
ndinsmore opened this issue Nov 27, 2020 · 4 comments
Closed

Resolution KW not working properly on OSX with retina GLMakie.jl #766

ndinsmore opened this issue Nov 27, 2020 · 4 comments

Comments

@ndinsmore
Copy link

If I use the code:

using AbstractPlotting, GLMakie
scene=Scene(resolution = AbstractPlotting.primary_resolution())
scene

I do not get a window that fills the whole screen as seen in the image below.
In this case AbstractPlotting.primary_resolution() = (2880,1600).
Furthermore, my screen resolution is set at 1920 x 1200, so there is already some oddity there.
image

Beyond that, there is some significant performance degradation when I have a window open.
Further documentation in discourse:
https://discourse.julialang.org/t/blank-glmakie-jl-window-make-system-unusable-while-open/50763

@SimonDanisch
Copy link
Member

For OSX, i haven't implemented the calls to get the primary resolution - which i started to do without GLFW present so it can be queried inside AbstractPlotting without any backend loaded. Since this has been troublesome also for the web backends, we may want to move this back into the backends, since that would make it much easier.

@ndinsmore
Copy link
Author

Would those calls make the window draw smaller than it should? Because the screen resolution is only set to 1960 x 1200. So I still am trying to figure out how that would make GLMakie draw a Scene that is bigger that the screen, as smaller than the screen.

@ndinsmore
Copy link
Author

Trying to dig deeper, I ran the tests for both CairoMakie and GLMakie.
CairoMakie passed all tests.
GLMakie did not:
ERROR: LoadError: Some tests did not pass: 52 passed, 57 failed, 8 errored, 0 broken.
All the tests ran but failed at the image comparison.
I am hoping that this is all stemming from a root issue.
Is there a way to run the test and keep the image assets of the failed test. I thought that if I dig through those I might beable to figure out what the common issue is.

@ffreyer
Copy link
Collaborator

ffreyer commented Aug 22, 2024

Fixed by #2544 in Makie 0.20 (and to a lesser degree beforehand)

@ffreyer ffreyer closed this as completed Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants