added support for custom "See all" close buttons #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zfoltin
reviewed
Feb 3, 2017
| if let closeButton = seeAllCloseButton { | ||
| thumbnailsController.closeButton = closeButton | ||
| thumbnailsController.closeLayout = seeAllCloseLayout | ||
| } else if let closeButton = closeButton { | ||
| let seeAllCloseButton = UIButton(frame: CGRect(origin: CGPoint.zero, size: closeButton.bounds.size)) | ||
| seeAllCloseButton.setImage(closeButton.image(for: UIControlState()), for: UIControlState()) |
There was a problem hiding this comment.
not related to this PR but this should be .normal instead of UIControlState()... will fix it at some point
|
LGTM 👍 Thanks @miex0r for contributing 👌 |
RuiAAPeres
reviewed
Feb 3, 2017
| case .seeAllCloseButtonMode(let buttonMode): | ||
|
|
||
| switch buttonMode { | ||
|
|
|
removed the extra line. NP @zfoltin - glad to help. love the plugin so far. another PR i may put in next week will be configuration around the thumbnail collection view cell cards. It would be cool to customize the style of those (custom shadows,margins,etc). |
|
👍 looking forward to the next PR :) There is a lot that could be improved on the thumbnails view |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was useful for me to have a unique button and button layout for the dismissal of the thumbnail view