Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlatformExceptions get plugin into a broken state #98

Closed
josh-burton opened this issue Mar 31, 2020 · 4 comments · Fixed by #99
Closed

PlatformExceptions get plugin into a broken state #98

josh-burton opened this issue Mar 31, 2020 · 4 comments · Fixed by #99

Comments

@josh-burton
Copy link
Contributor

I've seen a few times now where if I get a platform exception when calling a method on the plugin, the plugin gets into a broken state because it thinks there is a pending operation in progress.

It seems like any method call may need to be surrounded in a try/catch so the pending operation can be cancelled, before rethrowing the exception?

I've seen this on Android, not sure about iOS yet.

@MaikuB
Copy link
Owner

MaikuB commented Mar 31, 2020

Are there steps that can be used to reproduce this with the example app in this repo? I'm wondering if there's something that can be done as this does delegate most of the logic to the native SDK

@josh-burton
Copy link
Contributor Author

I came across the issue by passing in a null client id when authorizing, I think that should reproduce it.

@MaikuB
Copy link
Owner

MaikuB commented Apr 3, 2020

This should be fixed in 0.8.2 now

@josh-burton
Copy link
Contributor Author

thanks @MaikuB!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants