Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate redux to NgRx #3250

Closed
4 tasks done
shaman-apprentice opened this issue Mar 17, 2023 · 0 comments · Fixed by #3271
Closed
4 tasks done

Migrate redux to NgRx #3250

shaman-apprentice opened this issue Mar 17, 2023 · 0 comments · Fixed by #3271
Assignees
Labels
tech For technical stories without user impact (=refactoring stories).

Comments

@shaman-apprentice
Copy link

shaman-apprentice commented Mar 17, 2023

Maintenance

As a developer I don't want to mix different libraries and best practices, so that I can easily read existing code and need only one mindset for writing new code.

In ADR 8 angular migration we decided to use rxjs observerables and migrate to @ngrx/store.

While migrating from AngularJS to Angular we already introduced an ngrx/store like wrapper around redux here. For completing this transition we want to replace redux and this wrapper through a real ngrx/store.

Expected advantages

  • We can remove our custom minimal redux to NgRx wrapper. Instead we will have full NgRx API available
  • We can use NgRx testing utilities. This enables us for a cleaner mocking of selectors. We can likely reduce how often we initialise the complete store by a lot.
  • NgRx has better typings
  • NgRx boilder code is less verbose than redux's

Acceptance criteria

  • redux is replaced from package.json

Development notes (optional Task Breakdown)

  • Replace redux store through ngrx/store. This includes rewriting all actions and reducers.
  • Replace custom selectors through real selectors.
  • Replace custom effects through real effects.
  • Adjust tests
@shaman-apprentice shaman-apprentice added the tech For technical stories without user impact (=refactoring stories). label Mar 17, 2023
@shaman-apprentice shaman-apprentice self-assigned this Mar 20, 2023
shaman-apprentice pushed a commit that referenced this issue Mar 31, 2023
shaman-apprentice pushed a commit that referenced this issue Mar 31, 2023
shaman-apprentice pushed a commit that referenced this issue Mar 31, 2023
shaman-apprentice pushed a commit that referenced this issue Mar 31, 2023
shaman-apprentice pushed a commit that referenced this issue Mar 31, 2023
shaman-apprentice pushed a commit that referenced this issue Mar 31, 2023
shaman-apprentice pushed a commit that referenced this issue Mar 31, 2023
shaman-apprentice pushed a commit that referenced this issue Apr 2, 2023
shaman-apprentice pushed a commit that referenced this issue Apr 2, 2023
shaman-apprentice pushed a commit that referenced this issue Apr 2, 2023
shaman-apprentice pushed a commit that referenced this issue Apr 2, 2023
shaman-apprentice pushed a commit that referenced this issue Apr 7, 2023
shaman-apprentice pushed a commit that referenced this issue Apr 11, 2023
shaman-apprentice pushed a commit that referenced this issue Apr 11, 2023
as map called it with (every event increased by one) index, preventing memoization

ref #3250
shaman-apprentice pushed a commit that referenced this issue Apr 11, 2023
shaman-apprentice pushed a commit that referenced this issue Apr 11, 2023
shaman-apprentice pushed a commit that referenced this issue Apr 11, 2023
shaman-apprentice pushed a commit that referenced this issue Apr 11, 2023
shaman-apprentice pushed a commit that referenced this issue Apr 11, 2023
shaman-apprentice pushed a commit that referenced this issue Apr 11, 2023
shaman-apprentice pushed a commit that referenced this issue Apr 11, 2023
shaman-apprentice pushed a commit that referenced this issue Apr 11, 2023
shaman-apprentice pushed a commit that referenced this issue Apr 11, 2023
shaman-apprentice pushed a commit that referenced this issue Apr 13, 2023
shaman-apprentice pushed a commit that referenced this issue Apr 13, 2023
shaman-apprentice pushed a commit that referenced this issue Apr 13, 2023
shaman-apprentice pushed a commit that referenced this issue Apr 13, 2023
shaman-apprentice pushed a commit that referenced this issue Apr 16, 2023
shaman-apprentice pushed a commit that referenced this issue Apr 17, 2023
shaman-apprentice pushed a commit that referenced this issue Apr 17, 2023
All cases are already covered by sortNode and this was only clue code

ref #3250
shaman-apprentice pushed a commit that referenced this issue Apr 17, 2023
shaman-apprentice pushed a commit that referenced this issue Apr 18, 2023
shaman-apprentice pushed a commit that referenced this issue Apr 20, 2023
shaman-apprentice pushed a commit that referenced this issue Apr 20, 2023
shaman-apprentice pushed a commit that referenced this issue Apr 20, 2023
shaman-apprentice pushed a commit that referenced this issue Apr 21, 2023
shaman-apprentice pushed a commit that referenced this issue Apr 21, 2023
shaman-apprentice pushed a commit that referenced this issue Apr 22, 2023
shaman-apprentice pushed a commit that referenced this issue Apr 22, 2023
shaman-apprentice pushed a commit that referenced this issue Apr 22, 2023
shaman-apprentice pushed a commit that referenced this issue Apr 22, 2023
shaman-apprentice pushed a commit that referenced this issue Apr 23, 2023
shaman-apprentice pushed a commit that referenced this issue Apr 28, 2023
fix: color buildings of delta mode  again and replace redux through ngrx

Also fix at least one broken memorization leading to a lot of unnecessary calculations

close #3250
fix #3268 (which was probably caused by racing conditions)
shaman-apprentice pushed a commit that referenced this issue Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech For technical stories without user impact (=refactoring stories).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant