refactor: be more specific than any as derived typed

ref #3250
MaibornWolff · Apr 17, 2023 · eaef962 · eaef962
1 parent 9295318
commit eaef962
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/visualization/app/codeCharta/state/selectors/accumulatedData/accumulatedData.selector.ts b/visualization/app/codeCharta/state/selectors/accumulatedData/accumulatedData.selector.ts
@@ -13,12 +13,12 @@ import { metricDataSelector } from "./metricData/metricData.selector"
 import { createSelector } from "@ngrx/store"
 import { clone } from "../../../util/clone"
 
-const accumulatedDataFallback = Object.freeze({
+const accumulatedDataFallback: AccumulatedData = Object.freeze({
 	unifiedMapNode: undefined,
 	unifiedFileMeta: undefined
 })
 
-export type AccumulatedData = { unifiedMapNode: CodeMapNode; unifiedFileMeta: FileMeta }
+export type AccumulatedData = { unifiedMapNode: CodeMapNode | undefined; unifiedFileMeta: FileMeta | undefined }
 
 export const accumulatedDataSelector = createSelector(
 	metricDataSelector,

diff --git a/visualization/app/codeCharta/state/selectors/searchedNodes/getNodesByGitignorePath.ts b/visualization/app/codeCharta/state/selectors/searchedNodes/getNodesByGitignorePath.ts
@@ -3,7 +3,7 @@ import { hierarchy } from "d3-hierarchy"
 import { CodeMapNode } from "../../../codeCharta.model"
 import { returnIgnore, transformPath } from "../../../util/codeMapHelper"
 
-export function getNodesByGitignorePath(root: CodeMapNode, gitignorePath: string) {
+export function getNodesByGitignorePath(root: CodeMapNode, gitignorePath: string): CodeMapNode[] {
 	gitignorePath = gitignorePath.trimStart()
 	if (gitignorePath.length === 0 || !root) {
 		return []