Skip to content

Commit 702c2ca

Browse files
committed
fix: export crash on null container and dialog window titles
1 parent a7e6099 commit 702c2ca

File tree

4 files changed

+7
-0
lines changed

4 files changed

+7
-0
lines changed

src/hobbits-gui/mainwindow.cpp

+1
Original file line numberDiff line numberDiff line change
@@ -736,6 +736,7 @@ void MainWindow::requestExportRun(QString pluginName, QJsonObject pluginState)
736736
{
737737
if (currContainer().isNull()) {
738738
warningMessage("Cannot export without a selected bit container");
739+
return;
739740
}
740741
QSharedPointer<ImportExportInterface> plugin = m_pluginManager->getImporterExporter(pluginName);
741742
auto result = plugin->exportBits(currContainer(), pluginState, this);

src/hobbits-plugins/importerexporters/HexString/hexstringimporter.cpp

+2
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ HexStringImporter::HexStringImporter(QWidget *parent) :
99
ui(new Ui::HexStringImporter)
1010
{
1111
ui->setupUi(this);
12+
13+
setWindowTitle("Import Hex String");
1214
}
1315

1416
HexStringImporter::~HexStringImporter()

src/hobbits-plugins/importerexporters/TcpData/tcpreceiver.cpp

+2
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ TcpReceiver::TcpReceiver(QWidget *parent) :
1212
connect(m_server, &QTcpServer::newConnection, this, &TcpReceiver::manageConnection);
1313
m_downloadFile.open();
1414

15+
setWindowTitle("Import via TCP");
16+
1517
ui->pb_stop->setEnabled(false);
1618
}
1719

src/hobbits-plugins/importerexporters/TcpData/tcpsender.cpp

+2
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ TcpSender::TcpSender(QSharedPointer<const BitArray> bits, QWidget *parent) :
1212
ui->pb_cancel->setEnabled(false);
1313

1414
connect(m_socket.data(), &QTcpSocket::bytesWritten, this, &TcpSender::writeNextChunk);
15+
16+
setWindowTitle("Export via TCP");
1517
}
1618

1719
TcpSender::~TcpSender()

0 commit comments

Comments
 (0)