Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize lock window function #394

Open
Danie0918 opened this issue May 27, 2024 · 7 comments
Open

Optimize lock window function #394

Danie0918 opened this issue May 27, 2024 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@Danie0918
Copy link
Contributor

The current process lacks a reset feature during use, i.e., when the user is unable to restore the pin, rendering the wallet unusable.

  1. Add a reset function that requires verification of the user's wallet password.
  2. Reduced the multiple input error penalty to a 5-minute lockout for 3 errors.
  3. Encrypt the pin file to prevent manual bypass of the detection process.
  4. Hides the menu bar when the window is locked.
@Danie0918 Danie0918 added the enhancement New feature or request label May 27, 2024
@Danie0918 Danie0918 self-assigned this May 27, 2024
@Danie0918
Copy link
Contributor Author

Danie0918 commented Jun 3, 2024

Image
hard_wallet

  1. Add a reset process to reset the lock window password after verifying the user's current wallet password.
  2. Changed the penalty for failing to lock a window to 5 minutes for every 3 errors and no more.
  3. Lock window password file encryption to prevent manual bypass of the authentication process.

@Kirl70
Copy link

Kirl70 commented Jun 11, 2024

@yanguoyu yanguoyu self-assigned this Jun 11, 2024
@Danie0918 Danie0918 removed their assignment Jun 17, 2024
@yanguoyu
Copy link

yanguoyu commented Jun 19, 2024

Lock window password file encryption to prevent manual bypass of the authentication process.

No matter where the password file is saved, anyone who can access the computer can delete the file. Then the password will be invalid. Currently, the password has been encrypt.

Hides the menu bar when the window is locked.

Some menus have been hidden when the window is locked, do you mean hidden all of the menus?

@Danie0918
Copy link
Contributor Author

Lock window password file encryption to prevent manual bypass of the authentication process.

No matter where the password file is saved, anyone who can access the computer can delete the file. Then the password will be invalid. Currently, the password has been encrypt.

OK

Hides the menu bar when the window is locked.

Some menus have been hidden when the window is locked, do you mean hidden all of the menus?

image

Ignore this, because currently the Wallet&Tools menu is hidden.

@yanguoyu
Copy link

@Danie0918 We must consider the scenario where users only have hardware wallets for resetting lock passwords.

@Kirl70
Copy link

Kirl70 commented Jun 20, 2024

@Danie0918 We must consider the scenario where users only have hardware wallets for resetting lock passwords.

The hardware wallet process has been added to the design draft:
https://www.figma.com/design/6XNoimRDbFTTNm016rbIdU/Magickbase?node-id=39127-51510&t=ist2yudTcUR1yeqD-1
image

@yanguoyu
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🚩Pre Release
Development

No branches or pull requests

4 participants