Should we add network type field when the user add network

[yanguoyu]

If the user starts an external light client node and the Neuron selects the light client, it will notify the user to create a new network to switch or ignore. Weirdly, the user can not create a light client network. Then they can only ignore the external node.
@Keith-CY @Danie0918

[Danie0918]

If the user starts an external light client node and the Neuron selects the light client, it will notify the user to create a new network to switch or ignore. Weirdly, the user can not create a light client network. Then they can only ignore the external node. @Keith-CY @Danie0918

For the current situation, we need to label the type of network in subsequent releases.

[Keith-CY]

Connecting to an external light client is not allowed because the light client is based on different security assumptions.

Ref: #90 (comment)

[yanguoyu]

Connecting to an external light client is not allowed because the light client is based on different security assumptions.

Ref: #90 (comment)

So, If the user starts an external light client node, it will be better to only provide the Ignore external node option.

[Keith-CY]

Connecting to an external light client is not allowed because the light client is based on different security assumptions.
Ref: #90 (comment)

So, If the user starts an external light client node, it will be better to only provide the Ignore external node option.

If it's connected to an external light client, show the internal light client options as show external network options on connecting to an external node we have implemented.

[Danie0918]

Connecting to an external light client is not allowed because the light client is based on different security assumptions.
Ref: #90 (comment)

So, If the user starts an external light client node, it will be better to only provide the Ignore external node option.

For this case, our friendlier approach is to prompt the user that it is unavailable, which can be achieved by modifying the text based on a pop-up window detected by an external node.

Text: Neuron does not support external light client nodes due to different security assumptions for light clients. It has been switched to Neuron internal light client nodes for you.

[Keith-CY]

Connecting to an external light client is not allowed because the light client is based on different security assumptions.
Ref: #90 (comment)

So, If the user starts an external light client node, it will be better to only provide the Ignore external node option.

For this case, our friendlier approach is to prompt the user that it is unavailable, which can be achieved by modifying the text based on a pop-up window detected by an external node.

Text: Neuron does not support external light client nodes due to different security assumptions for light clients. It has been switched to Neuron internal light client nodes for you.

The sentence It has been switched to Neuron internal light client node for you conflicts with confirm because confirm is a request while ... has been ... is a notification. What if Would you like to connect to the internal CKB Light Client(mainnet/testnet), (mainnet/testnet) based on type of the external one.

[Danie0918]

Connecting to an external light client is not allowed because the light client is based on different security assumptions.
Ref: #90 (comment)

So, If the user starts an external light client node, it will be better to only provide the Ignore external node option.

For this case, our friendlier approach is to prompt the user that it is unavailable, which can be achieved by modifying the text based on a pop-up window detected by an external node.
Text: Neuron does not support external light client nodes due to different security assumptions for light clients. It has been switched to Neuron internal light client nodes for you.

The sentence It has been switched to Neuron internal light client node for you conflicts with confirm because confirm is a request while ... has been ... is a notification. What if Would you like to connect to the internal CKB Light Client(mainnet/testnet), (mainnet/testnet) based on type of the external one.

How about adjusting confirm to OK?
When an external node is not available, we should automatically switch to an available internal node for the user.

[Keith-CY]

Connecting to an external light client is not allowed because the light client is based on different security assumptions.
Ref: #90 (comment)

So, If the user starts an external light client node, it will be better to only provide the Ignore external node option.

For this case, our friendlier approach is to prompt the user that it is unavailable, which can be achieved by modifying the text based on a pop-up window detected by an external node.
Text: Neuron does not support external light client nodes due to different security assumptions for light clients. It has been switched to Neuron internal light client nodes for you.

The sentence It has been switched to Neuron internal light client node for you conflicts with confirm because confirm is a request while ... has been ... is a notification. What if Would you like to connect to the internal CKB Light Client(mainnet/testnet), (mainnet/testnet) based on type of the external one.

How about adjusting confirm to OK? When an external node is not available, we should automatically switch to an available internal node for the user.

I'm not sure, personally I don't like an automatic switch because it makes me feel out of control.

[Danie0918]

Connecting to an external light client is not allowed because the light client is based on different security assumptions.
Ref: #90 (comment)

So, If the user starts an external light client node, it will be better to only provide the Ignore external node option.

For this case, our friendlier approach is to prompt the user that it is unavailable, which can be achieved by modifying the text based on a pop-up window detected by an external node.
Text: Neuron does not support external light client nodes due to different security assumptions for light clients. It has been switched to Neuron internal light client nodes for you.

The sentence It has been switched to Neuron internal light client node for you conflicts with confirm because confirm is a request while ... has been ... is a notification. What if Would you like to connect to the internal CKB Light Client(mainnet/testnet), (mainnet/testnet) based on type of the external one.

How about adjusting confirm to OK? When an external node is not available, we should automatically switch to an available internal node for the user.

I'm not sure, personally I don't like an automatic switch because it makes me feel out of control.

Ok, the plan is as follows:

Prompt the user when they start an external light client node and selected a Neuron internal node and guide them to use the Neuron internal light client. Click Confirm to connect to the Neuron internal light client and Ignore external node to continue linking to the selected Neuron internal node.

Text: Neuron does not support external light client nodes due to different security assumptions for light clients. Would you like to connect to the internal CKB Light Client?

[Keith-CY]

Connecting to an external light client is not allowed because the light client is based on different security assumptions.
Ref: #90 (comment)

So, If the user starts an external light client node, it will be better to only provide the Ignore external node option.

For this case, our friendlier approach is to prompt the user that it is unavailable, which can be achieved by modifying the text based on a pop-up window detected by an external node.
Text: Neuron does not support external light client nodes due to different security assumptions for light clients. It has been switched to Neuron internal light client nodes for you.

The sentence It has been switched to Neuron internal light client node for you conflicts with confirm because confirm is a request while ... has been ... is a notification. What if Would you like to connect to the internal CKB Light Client(mainnet/testnet), (mainnet/testnet) based on type of the external one.

How about adjusting confirm to OK? When an external node is not available, we should automatically switch to an available internal node for the user.

I'm not sure, personally I don't like an automatic switch because it makes me feel out of control.

Ok, the plan is as follows:

Prompt the user when they start an external light client node and selected a Neuron internal node and guide them to use the Neuron internal light client. Click Confirm to connect to the Neuron internal light client and Ignore external node to continue linking to the selected Neuron internal node.

Text: Neuron does not support external light client nodes due to different security assumptions for light clients. Would you like to connect to the internal CKB Light Client?

LGTM

[yanguoyu]

What is the difference between Ignore external node and Confirm? @Danie0918

[Danie0918]

What is the difference between Ignore external node and Confirm? @Danie0918

Ignore external node:Along with the chosen node, there is a possibility of full node.
Confirm:Switch to the Neuron internal light client and switch to the same type of network depending on the type of external node (mainnet/testnet).

[yanguoyu]

What is the difference between Ignore external node and Confirm? @Danie0918

Ignore external node:Along with the chosen node, there is a possibility of full node. Confirm:Switch to the Neuron internal light client and switch to the same type of network depending on the type of external node (mainnet/testnet).

If the user selects the light client, the external node must be a service whose remote is equal to the light client.
So I'm confused about the difference after clicking Ignore or Confirm.

[Danie0918]

What is the difference between Ignore external node and Confirm? @Danie0918

Ignore external node:Along with the chosen node, there is a possibility of full node. Confirm:Switch to the Neuron internal light client and switch to the same type of network depending on the type of external node (mainnet/testnet).

If the user selects the light client, the external node must be a service whose remote is equal to the light client. So I'm confused about the difference after clicking Ignore or Confirm.

Yes, the results are the same when the internal light client is selected.

[yanguoyu]

What is the difference between Ignore external node and Confirm? @Danie0918

Ignore external node:Along with the chosen node, there is a possibility of a full node. Confirm:Switch to the Neuron internal light client and switch to the same type of network depending on the type of external node (mainnet/testnet).

If the user selects the light client, the external node must be a service whose remote is equal to the light client. So I'm confused about the difference after clicking Ignore or Confirm.

Yes, the results are the same when the internal light client is selected.

So, If the user selects Light Client and detects an external light client node, how about only showing the Confirm button, if there exist two same action options with different texts, users will be confused.

[Danie0918]

So, If the user selects Light Client and detects an external light client node, how about only showing the Confirm button, if there exist two same action options with different texts, users will be confused.

This would still have the problem mentioned before: it would make the user feel out of control. It would also increase the complexity of the code, so it is recommended to keep the 2 options.

[Danie0918]

Will be fixed in #375