Unlock DAO failed with light client

[yanguoyu]

RPC method calculateDaoMaximumWithdraw was not in the light client. After replacing ckb-sdk-js with lumos, it throws an error that method not found. The calculateDaoMaximumWithdraw method in ckb-sdk-js is not the same as the lumos.

calculateDaoMaximumWithdraw in ckb-sdk-js
https://github.com/ckb-js/ckb-sdk-js/blob/develop/packages/ckb-sdk-core/src/index.ts#L423-L452
calculateDaoMaximumWithdraw in lumos
https://github.com/ckb-js/lumos/blob/develop/packages/rpc/src/Base/experimental.ts#L10-L13

[Keith-CY]

The RPC https://github.com/nervosnetwork/ckb/tree/develop/rpc#method-calculate_dao_maximum_withdraw will be removed in the future, so the amount should be calculated offline.

Ref: https://github.com/Magickbase/neuron-internal/issues/1380

[homura]

Maybe we can migrate to this method calculateMaximumWithdrawCompatible, but it is a little more work than before.

public calculateDaoMaximumWithdraw = async (
    depositOutPoint: OutPoint,
    withdrawBlockHash: string
  ): Promise<bigint> => {
    const currentNetwork = NetworksService.getInstance().getCurrent()
    const ckb = new CKBRPC(currentNetwork.remote)
-   const result = await ckb.calculateDaoMaximumWithdraw(depositOutPoint.toSDK(), withdrawBlockHash)
+   const depositHeader = await ckb.getHeader(depositBlockHash)
+   const withdrawHeader = await ckb.getHeader(withdrawBlockHash)
+   const withdrawCell = await ckb.getLiveCell(depositOutPoint.txHash)
+   return calculateMaximumWithdrawCompatible(withdrawCell, depositHeader.dao, withdrawHeader.dao)
  }

[Keith-CY]

Maybe we can migrate to this method calculateMaximumWithdrawCompatible, but it is a little more work than before.

public calculateDaoMaximumWithdraw = async (
    depositOutPoint: OutPoint,
    withdrawBlockHash: string
  ): Promise<bigint> => {
    const currentNetwork = NetworksService.getInstance().getCurrent()
    const ckb = new CKBRPC(currentNetwork.remote)
-   const result = await ckb.calculateDaoMaximumWithdraw(depositOutPoint.toSDK(), withdrawBlockHash)
+   const depositHeader = await ckb.getHeader(depositBlockHash)
+   const withdrawHeader = await ckb.getHeader(withdrawBlockHash)
+   const withdrawCell = await ckb.getLiveCell(depositOutPoint.txHash)
+   return calculateMaximumWithdrawCompatible(withdrawCell, depositHeader.dao, withdrawHeader.dao)
  }

I found the method calculateDaoMaximumWithdraw can be done with this feature implementation Magickbase/ckb-explorer-public-issues#462 in CKB Explorer.

[yanguoyu]

const withdrawCell = await ckb.getLiveCell(depositOutPoint.txHash)

The light client does not have the RPC named get_live_cell. Maybe it's better to get the live cell by another RPC method.

[Keith-CY]

Why not reuse the logic implemented at https://github.com/ckb-js/ckb-sdk-js/blob/develop/packages/ckb-sdk-core/src/index.ts#L423-L452

[homura]

The light client does not have the RPC named get_live_cell. Maybe it's better to get the live cell by another RPC method.

you're right, we should use the piece of the logic below, by using get_transaction function instead

Why not reuse the logic implemented at ckb-js/ckb-sdk-js@develop/packages/ckb-sdk-core/src/index.ts#L423-L452

[Keith-CY]

The light client does not have the RPC named get_live_cell. Maybe it's better to get the live cell by another RPC method.

you're right, we should use the piece of the logic below, by using get_transaction function instead

Why not reuse the logic implemented at ckb-js/ckb-sdk-js@develop/packages/ckb-sdk-core/src/index.ts#L423-L452

Now it should be simple to fix because code snippets and test cases are ready, can we prioritize this fix in lumos so unlock nervos dao can be fixed by upgrading the SDK?

[homura]

Now it should be simple to fix because code snippets and test cases are ready, can we prioritize this fix in lumos so unlock nervos dao can be fixed by upgrading the SDK?

I've tried to fix the issue but I am struggling to verify it with the light client. It currently functions properly with the full node, but I'm unsure why the light client with devnet is unable to work with Neuron.

Screen.Recording.2023-11-17.at.17.01.39.mov