Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tag column for xUDT list with a tag filter on it #650

Open
Sven-TBD opened this issue May 8, 2024 · 9 comments
Open

Add tag column for xUDT list with a tag filter on it #650

Sven-TBD opened this issue May 8, 2024 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@Sven-TBD
Copy link
Contributor

Sven-TBD commented May 8, 2024

A Tag column should be inserted into the xUDT list page with a filter function which should show the checked tag and the status of ON & OFF

Image

@Sven-TBD Sven-TBD added the enhancement New feature or request label May 8, 2024
@Daryl-L
Copy link

Daryl-L commented Jun 13, 2024

Two changes should be published by backend API.

  1. API for querying the list of all tags.
  2. The filter in the parameter for API /api/v1/xudts should be added.

@zmcNotafraid
Copy link
Member

zmcNotafraid commented Jun 24, 2024

Already achieve at: nervosnetwork/ckb-explorer#1794
api: /api/v1/xudts?tags=A,B,C
All tags: ["unnamed", "invalid", "suspicious", "out-of-length-range", "rgbpp-compatible", "layer-1-asset", "supply-limited", "duplicate", "layer-2-asset", "supply-unlimited"]


Token Collection tags: ["invalid", "suspicious", "out-of-length-range", "rgbpp-compatible", "layer-1-asset", "duplicate", "layer-2-asset"]
@Daryl-L

@zmcNotafraid zmcNotafraid removed their assignment Jun 24, 2024
@Daryl-L
Copy link

Daryl-L commented Jun 24, 2024

Already achieve at: nervosnetwork/ckb-explorer#1794 api: /api/v1/xudts?tags=A,B,C All tags: ["unnamed", "invalid", "suspicious", "out-of-length-range", "rgbpp-compatible", "layer-1-asset", "supply-limited", "duplicate", "layer-2-asset", "supply-unlimited"]

Token Collection tags: ["invalid", "suspicious", "out-of-length-range", "rgbpp-compatible", "layer-1-asset", "duplicate", "layer-2-asset"] @Daryl-L

https://ckb-explorer-api.staging.layerview.io/api/v1/xudts?page=1&page_size=10&sort=transactions.desc&tags=invalid,suspicious

Not work for multiple tags selectd.

@Daryl-L
Copy link

Daryl-L commented Jun 24, 2024

@zmcNotafraid
Copy link
Member

@FrederLu
Copy link

@Daryl-L
Copy link

Daryl-L commented Jul 16, 2024

Default request URL: https://testnet-api.explorer.nervos.org/api/v1/xudts?page=1&page_size=10&sort=transactions.desc&union=true

Image

Select all request URL: https://testnet-api.explorer.nervos.org/api/v1/xudts?page=1&page_size=10&sort=transactions.desc&tags=out-of-length-range,layer-1-asset,layer-2-asset,supply-limited,supply-unlimited,rgbpp-compatible&union=true

Image

The xudt list data needs to remain consistent in the default and all-select situations, but now the two data are different.

Some token in the stage env do not have a tag, so they will not be listed when all seleted. And according to @zmcNotafraid there will not be any tokens with no tag in the testnet and the mainnet.

@FrederLu
Copy link

FrederLu commented Jul 17, 2024

Default request URL: https://testnet-api.explorer.nervos.org/api/v1/xudts?page=1&page_size=10&sort=transactions.desc&union=true

Image

Select all request URL: https://testnet-api.explorer.nervos.org/api/v1/xudts?page=1&page_size=10&sort=transactions.desc&tags=out-of-length-range,layer-1-asset,layer-2-asset,supply-limited,supply-unlimited,rgbpp-compatible&union=true

Image

The xudt list data needs to remain consistent in the default and all-select situations, but now the two data are different.

Currently, the optional tag information is less than the default data. This situation will remain the same for now, and the tags will be optimized later.
Verified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

No branches or pull requests

5 participants