Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] Always use lock hash to interact with API #246

Open
2 tasks
ShiningRay opened this issue Mar 29, 2023 · 1 comment
Open
2 tasks

[Frontend] Always use lock hash to interact with API #246

ShiningRay opened this issue Mar 29, 2023 · 1 comment
Assignees
Labels

Comments

@ShiningRay
Copy link
Contributor

ShiningRay commented Mar 29, 2023

The CKB address has serveral different format due to history reason.
But these formats are all computed based on lock hash -- the script hash of lock script.
So it's safe to use lock hash instead of address hash when communicating with server side.
And this will enable user to switch the format he/she wants on client side.

  • generate address hash based on lock hash and show
  • send lock hash instead of address hash .
@Danie0918 Danie0918 self-assigned this Apr 3, 2023
@Sven-TBD
Copy link
Contributor

Updated from mingchang:
It seems the impact is minimal, so no adjustments are needed.

So I put this into hold on and adjust its priority

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 📫Hold On
Development

No branches or pull requests

4 participants