Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markers missing on pipenv-setup check #119

Open
jrottenberg opened this issue Apr 29, 2022 · 1 comment
Open

Markers missing on pipenv-setup check #119

jrottenberg opened this issue Apr 29, 2022 · 1 comment

Comments

@jrottenberg
Copy link
Contributor

Description

Running pipenv-setup check for a Pipfile that has a marker (PEP 496) should fail if the marker is not in the setup.py.
Note: the pipenv-setup sync propagates the marker, we do see it in the setup.py, but the check is not enforcing it.

Steps to Reproduce

Pipfile

[[source]]
verify_ssl = true

[packages]
pyqt5 = {version = "*", sys_platform = "!= 'Linux'"}


[requires]
python_version = "3"

setup.py

[...]
    install_requires=["pyqt5"],
[...]

Expected

package 'pyqt5' in pipfile but no marker in install_requires

Got

pipenv-setup  check
No version conflict or missing packages/dependencies found in setup.py!

Note : pipenv-setup sync will do the right thing, but the check should tell us if sync would generate a file different from the current setup.py.

@Madoshakalaka
Copy link
Owner

Thanks for reporting, will implement this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants