Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use user display name instead of their unique name #16

Closed
LoneWolfHT opened this issue Jun 14, 2023 · 2 comments
Closed

Use user display name instead of their unique name #16

LoneWolfHT opened this issue Jun 14, 2023 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@LoneWolfHT
Copy link
Member

e.g LandarVargan instead of landarvargan
image
@LoneWolfHT LoneWolfHT added enhancement New feature or request good first issue Good for newcomers labels Jun 14, 2023
@AFCMS
Copy link
Contributor

AFCMS commented Jun 29, 2023

Need upcoming Discord.js v14.12 (discordjs/discord.js#9512) to be done properly.

Will look into it.

@AFCMS
Copy link
Contributor

AFCMS commented Jun 30, 2023

GuildMember.displayName currently return the nickname or the username if nickname doesn't exist for the guild

The PR seem to make this property use the new User.displayName property instead of the username, so we can migrate the code to use GuildMember.displayName and then just bump to v14.12 when available.

Will work on it.

@AFCMS AFCMS mentioned this issue Jul 3, 2023
Merged
2 tasks
@pure-adachi pure-adachi mentioned this issue Jul 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LoneWolfHT @AFCMS