diff --git a/keyboards/converter/ibm_5291/config.h b/keyboards/converter/ibm_5291/config.h index 59ec04cfb478..ebb8c6e3bee5 100644 --- a/keyboards/converter/ibm_5291/config.h +++ b/keyboards/converter/ibm_5291/config.h @@ -25,13 +25,13 @@ along with this program. If not, see . #define MANUFACTURER QMK #define PRODUCT 5291 keyboard converter -#define MATRIX_ROWS 5 +#define MATRIX_ROWS 24 #define MATRIX_COLS 4 -#define MATRIX_ROW_PINS {B2, B3, B4, B5, B6} -#define MATRIX_COL_PINS {B0, B1} -#define MATRIX_DATA_PIN D0 -#define MATRIX_STROBE_PIN D1 +#define IBM_5291_MATRIX_ROW_PINS {B2, B3, B4, B5, B6} +#define IBM_5291_MATRIX_COL_PINS {B0, B1} +#define IBM_5291_MATRIX_DATA_PIN D0 +#define IBM_5291_MATRIX_STROBE_PIN D1 #define LED_PIN D6 diff --git a/keyboards/converter/ibm_5291/matrix.c b/keyboards/converter/ibm_5291/matrix.c index 3946d02e518d..8ee914eebaab 100644 --- a/keyboards/converter/ibm_5291/matrix.c +++ b/keyboards/converter/ibm_5291/matrix.c @@ -46,8 +46,8 @@ along with this program. If not, see . #define NUM_ROW_PINS 5 #define NUM_COL_PINS 2 -static const uint8_t row_pins [NUM_ROW_PINS] = MATRIX_ROW_PINS ; -static const uint8_t col_pins [NUM_ROW_PINS] = MATRIX_COL_PINS ; +static const uint8_t row_pins [NUM_ROW_PINS] = IBM_5291_MATRIX_ROW_PINS ; +static const uint8_t col_pins [NUM_ROW_PINS] = IBM_5291_MATRIX_COL_PINS ; #if ( DEBOUNCE > 0 ) static uint16_t debouncing_time ; @@ -78,7 +78,7 @@ void init_led(void) { static inline void init_data(void) { - uint8_t pin = MATRIX_DATA_PIN ; + uint8_t pin = IBM_5291_MATRIX_DATA_PIN ; _SFR_IO8((pin >> 4) + 1) &= ~_BV(pin & 0xF); // IN _SFR_IO8((pin >> 4) + 2) |= _BV(pin & 0xF); // LO } @@ -86,7 +86,7 @@ void init_data(void) { static inline void init_strobe(void) { - uint8_t pin = MATRIX_STROBE_PIN ; + uint8_t pin = IBM_5291_MATRIX_STROBE_PIN ; _SFR_IO8((pin >> 4) + 1) |= _BV(pin & 0xF); // OUT _SFR_IO8((pin >> 4) + 2) |= _BV(pin & 0xF); // HI } @@ -142,8 +142,8 @@ void select_col(uint8_t current_col) { static inline uint8_t matrix_strobe(uint8_t col_index) { - uint8_t strobe_pin = MATRIX_STROBE_PIN ; - uint8_t data_pin = MATRIX_DATA_PIN ; + uint8_t strobe_pin = IBM_5291_MATRIX_STROBE_PIN ; + uint8_t data_pin = IBM_5291_MATRIX_DATA_PIN ; // set strobe pin low _SFR_IO8((strobe_pin >> 4) + 2) &= ~_BV(strobe_pin & 0xF); diff --git a/users/mmcm/mmcm.sh b/users/mmcm/mmcm.sh index cff0f270b0cb..1cc377f028ea 100755 --- a/users/mmcm/mmcm.sh +++ b/users/mmcm/mmcm.sh @@ -90,4 +90,5 @@ make clueboard/2x1800/2019:mmcm SILENT=true && make converter/memorex_2051 SILENT=true && make keebio/bdn9/rev2:mmcm SILENT=true && make converter/nec_pc_8801 SILENT=true && +make converter/ibm_5291 SILENT=true && true