Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emailobject.py does not parse all Received header attributes correctly #1321

Closed
samitainio opened this issue Mar 23, 2025 · 0 comments · Fixed by #1322
Closed

Emailobject.py does not parse all Received header attributes correctly #1321

samitainio opened this issue Mar 23, 2025 · 0 comments · Fixed by #1322
Assignees

Comments

@samitainio
Copy link
Contributor

I have a PR coming up for this issue.

The current version of the emailobject.py file does not properly take into account that there can be multiple interesting attributes defined in a single Received header line.

Example: Received: from spam.sender.com (11-22-33-44.static.vps.com. [11.22.33.44])

In this example our previous version of the script would have been able to pick up the hostname spam.sender.com and the IP address 11.22.33.44. However back in the day, ahem when I wrote the previous version - sorry about that, it was not considered that also Reverse DNS (PTR) Hostname or in this example the hostname 11-22-33-44.static.vps.com would also be relevant to pick up.

There is a PR coming that will fix my past mistake and also otherwise improve on the logic how the Received headers are handled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants