Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial_he3 is doubly defined #766

Open
Mathijs-Vanrespaille opened this issue Jan 22, 2025 · 1 comment
Open

initial_he3 is doubly defined #766

Mathijs-Vanrespaille opened this issue Jan 22, 2025 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@Mathijs-Vanrespaille
Copy link

I'm using the latest stable MESA version 24.08.1, but also noticed this issue persists in version 24.03.1

The namelist object 'initial_he3' is used in both the star_job and controls namelists of the inlist. Bizarely enough, it seems to be the only one of its kind to be doubly defined as e.g. 'initial_he4' is only used in star_job. The one in star_job has the following documentation:

initial mass fraction of he3. Must be smaller than initial_y. (< 0 means use default which is taken as solar scaled such that he4/he3 has the same value as the Sun)
not used when loading a saved model or a zams model.

while the one in controls has no documentation at all. Do these two objects do the same thing? If so, please remove one (preferably the one in controls as the other initial_ are in star_job). If not, please clarify the difference in the documentation and rename one or both to emphasise that difference.

@Debraheem Debraheem added the documentation Improvements or additions to documentation label Jan 23, 2025
@Debraheem
Copy link
Member

Debraheem commented Jan 23, 2025

Hi @Mathijs-Vanrespaille, thanks for raising this. It appears the 'initial_he3' and other neighboring controls in start_job are only used when set_uniform_initial_composition = .true., which is .false. by default. see https://docs.mesastar.org/en/latest/reference/star_job.html#set-uniform-initial-composition.

In fact i was and still am a little confused by what the difference is between setting set_uniform_initial_composition = .true. or .false. .

I will investigate further, but either way we can add some documentation to clarify this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants