New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in backward BidirectionalPropagation #58

Open

kudashev opened this issue Mar 23, 2023 · 1 comment

kudashev commented Mar 23, 2023

When 'backward' propagation is applied, flow_idx was forgotten to be reversed as well here:

https://github.com/MCG-NKU/E2FGVI/blob/master/model/modules/feat_prop.py#L101

Code was copied inaccurate from BasicVSR++, please refer to:
https://github.com/ckkelvinchan/BasicVSR_PlusPlus/blob/master/mmedit/models/backbones/sr_backbones/basicvsr_pp.py#L180

The text was updated successfully, but these errors were encountered:

Collaborator

Paper99 commented Apr 25, 2023

Thank you for pointing out this. 👍
For reproducibility, we decided to keep the original code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment