Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ListAlbum fix #2753

Merged
merged 1 commit into from
Nov 27, 2024
Merged

ListAlbum fix #2753

merged 1 commit into from
Nov 27, 2024

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Nov 27, 2024

When titles are too long, the reduction could lead to negative number triggering an exception.

@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Nov 27, 2024
@ildyria ildyria requested a review from d7415 November 27, 2024 16:13
@codecov Codecov
Copy link

codecov bot commented Nov 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.63%. Comparing base (7df5e54) to head (09ee27f).
Report is 4 commits behind head on master.

Additional details and impacted files

@ildyria ildyria merged commit 46d58c5 into master Nov 27, 2024
49 checks passed
@ildyria ildyria deleted the fix-mb-string-limit branch November 27, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d7415 d7415 d7415 approved these changes

Assignees
No one assigned
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ildyria @d7415