Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PECL Drop-in Replacement vs Function Defaults #23

Open
jb-lopez opened this issue Feb 4, 2025 · 0 comments
Open

PECL Drop-in Replacement vs Function Defaults #23

jb-lopez opened this issue Feb 4, 2025 · 0 comments

Comments

@jb-lopez
Copy link
Contributor

jb-lopez commented Feb 4, 2025

In the README there's this statement under Usage -> Drop-In Replacement

This library is intended to be a drop-in replacement for the Trader extension, it comes with a polyfill for the Trader extension.

Further down in the README, there's this statement under Usage -> Note about default values

This package uses the C/Java defaults and not the PECL defaults.

These two statements are at odds with each other. If this library is a drop-in replacement for the PECL library, then it should use the PECL defaults for the defaults, and not the C/Java defaults.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant