Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Luos keep receiving messages from zombie (excluded) services. #451

Closed
nicolas-rabault opened this issue Nov 16, 2023 · 1 comment · Fixed by #453
Closed

[BUG] Luos keep receiving messages from zombie (excluded) services. #451

nicolas-rabault opened this issue Nov 16, 2023 · 1 comment · Fixed by #453
Assignees
Milestone

Comments

@nicolas-rabault
Copy link
Member

Which version the bug has been detected on

Luos engine 2.X.X, but this bug still occurs on version 3.

Description of the bug

The Gate service is one of the only packages using the polling methodology to retrieve messages. The gate manages the messages service by service. If a service is excluded it will no longer be managed by the Gate. So if The Gate excludes some services due to temporary no response, if those services continue to send data to the Gate, messages will stack and overflow the RAM.

Possible solutions

Accepting messages from zombie services/nodes or non-referenced services/nodes is a security issue. It is very difficult to fix it on version 2.X.X, so this needs to be fixed on version 3.0.0.

@nicolas-rabault nicolas-rabault added this to the 3.0.0 milestone Nov 16, 2023
@nicolas-rabault nicolas-rabault self-assigned this Nov 16, 2023
@nicolas-rabault
Copy link
Member Author

To fix this I had to add a condition on the reception filters. This operation may be done in IRQ (depending on the network), but we have no other choice.
Thanks to this we now have good behavior.
Screenshot 2023-11-22 at 10 40 01

@nicolas-rabault nicolas-rabault linked a pull request Nov 22, 2023 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant