Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure all screenshot paths that can fail print a message #1853

Open
bradgrantham-lunarg opened this issue Oct 31, 2024 · 0 comments · May be fixed by #1855
Open

Make sure all screenshot paths that can fail print a message #1853

bradgrantham-lunarg opened this issue Oct 31, 2024 · 0 comments · May be fixed by #1855
Assignees
@antonio-lunarg

Comments

@bradgrantham-lunarg
Copy link
Contributor

Discovered a path in ScreenshotHandler::WriteImage that failed silently if MapMemory failed. Every path that may fail to write a screenshot should cause a GFXRECON_LOG_FATAL or at least ERROR because failure to write a screenshot would be unexpected and probably break the next step in a pipeline of commands, e.g. CI.
@antonio-lunarg antonio-lunarg self-assigned this Nov 1, 2024
@antonio-lunarg antonio-lunarg linked a pull request Nov 1, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antonio-lunarg antonio-lunarg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

screenshot: Print message on memory map failure antonio-lunarg/gfxreconstruct
2 participants
@bradgrantham-lunarg @antonio-lunarg