Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local workspace.dependencies versions are not being masked #167

Closed
TitanNano opened this issue Nov 8, 2022 · 0 comments · Fixed by #171
Closed

Local workspace.dependencies versions are not being masked #167

TitanNano opened this issue Nov 8, 2022 · 0 comments · Fixed by #171
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@TitanNano
Copy link

The version masking of local dependencies is not being applied to local workspace dependencies that are defined in the root Cargo.toml under [workspace.dependencies]. This causes the version resolution to fail in cargo cook

https://github.com/LukeMathWalker/cargo-chef/blob/main/src/skeleton/version_masking.rs#L71
only handles dependencies under target.* and without any prefix. It should be extended by the workspace parent key.

@LukeMathWalker LukeMathWalker added the bug Something isn't working label Nov 8, 2022
@LukeMathWalker LukeMathWalker added the good first issue Good for newcomers label Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants