-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Auth with Plex #14
Comments
Notes for future me:
|
I think it would be good to think of some use cases before just authing everything
I guess it would make sense to keep a way for account-less people to join an existing room. |
|
I'd love to have an auth system in place. It's the one thing stopping me from adding it to my reverse proxy to be "public". Two user cases I can think of:
|
It would probably be better to use an application/oauth flow instead of having to put your username/password into moviematch to then pass on to plex. |
Here's how I've implemented the auth flow: Screen.Recording.2021-02-21.at.22.31.08.movIf you use 2FA Plex's login page will take care of it. |
Does this handle home users? or only logging in using the plex account? |
Only logging in with a Plex account at the moment, although the dev branch is far from ready at the moment (still working on filters). Finding out that the user is on the same network as the Plex server might need DNS-SD, which isn't something I can do in a web app. You might need to log in with the server owner's Plex account to be able to use a home user, but I'll have to look into it more if I get time. |
Is your feature request related to a problem? Please describe.
It would be nice to be able to auth with Plex in order to not let anyone see what films you've got in your libraries.
You could also use this to pre-fill names for the users and get some nice pictures if they have them set up
Describe the solution you'd like
Use Plex SSO and check if the machine ID matches the server
Describe alternatives you've considered
using a reverse proxy with some other SSO/Auth mechanism
Additional context
N/A
The text was updated successfully, but these errors were encountered: