Ensure cleanup on hotplug_libusb shutdown #172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emaxx-google
force-pushed
the
libusb-rescan-shutdown
branch
from
07749bc
to
1f21b5c
Compare
Make sure the hotplug_libusb cleanup code is executed on all exit branches from the thread. This prevents memory and resource leaks on these codepaths. Before the commit, it was possible that the cleanup code in HPRescanUsbBus() would be skipped if the caller (HPEstablishUSBNotifications()) decides to exit on its own. Also libusb_exit() was skipped in some branches. The commit moves the cleanup code to the end of HPEstablishUSBNotifications() and removes pthread_exit() from HPRescanUsbBus(), so that cleanup isn't skipped.
emaxx-google
force-pushed
the
libusb-rescan-shutdown
branch
from
1f21b5c
to
53859e0
Compare
emaxx-google
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure the hotplug_libusb cleanup code is executed on all exit
branches from the thread. This prevents memory and resource leaks
on these codepaths.
Before the commit, it was possible that the cleanup code in
HPRescanUsbBus() would be skipped if the caller
(HPEstablishUSBNotifications()) decides to exit on its own. Also
libusb_exit() was skipped in some branches.
The commit moves the cleanup code to the end of
HPEstablishUSBNotifications() and removes pthread_exit() from
HPRescanUsbBus(), so that cleanup isn't skipped.