diff --git a/docs/pr-discussions/PR-5274-fix-4733-remove-sensitive-information-and-fix-schema-errors.md b/docs/pr-discussions/PR-5274-fix-4733-remove-sensitive-information-and-fix-schema-errors.md new file mode 100644 index 0000000000..1c66161cf5 --- /dev/null +++ b/docs/pr-discussions/PR-5274-fix-4733-remove-sensitive-information-and-fix-schema-errors.md @@ -0,0 +1,62 @@ +--- +pr_number: 5274 +title: "fix(4733): remove sensitive information and fix schema errors (rebased)" +author: "AceHack" +state: "MERGED" +created_at: "2026-05-26T18:21:52Z" +merged_at: "2026-05-26T19:12:21Z" +closed_at: "2026-05-26T19:12:21Z" +head_ref: "lior/fix-4822-conflicts" +base_ref: "main" +archived_at: "2026-05-26T20:18:29Z" +archive_tool: "tools/pr-preservation/archive-pr.ts" +--- + +# PR #5274: fix(4733): remove sensitive information and fix schema errors (rebased) + +## PR description + +This PR supersedes #4733 and #4822. It removes sensitive personal information and fixes schema errors. The conflicts with main have been resolved. + +## Reviews + +### COMMENTED — @copilot-pull-request-reviewer (2026-05-26T18:24:42Z) + +## Pull request overview + +This PR removes sensitive personal-information-containing memory artifacts and attempts to reconcile `memory/MEMORY.md` after rebasing, in line with the goal of fixing schema/index issues introduced by prior work. + +**Changes:** +- Delete two memory artifacts containing sensitive personal information. +- Update `memory/MEMORY.md` auto-index content to reflect the current memory set after rebase. +- (Needs follow-up) Resolve duplicated auto-generated metadata lines in `memory/MEMORY.md` introduced by conflict/regen drift. + +### Reviewed changes + +Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments. + +| File | Description | +| ---- | ----------- | +| memory/persona/riven/conversations/2026-05-22-aaron-riven-full-session-substrate-trajectory.md | Deleted to remove sensitive session content. | +| memory/MEMORY.md | Auto-index updated, but currently contains duplicated stack/heap header and footer lines that should be resolved. | +| memory/feedback_aaron_family_configuration_cooperative_substrate_2026_05_22.md | Deleted to remove sensitive family-configuration content. | + +## Review threads + +### Thread 1: memory/MEMORY.md:6 (resolved) + +**@copilot-pull-request-reviewer** (2026-05-26T18:24:41Z): + +P0: `memory/MEMORY.md` currently has two consecutive “Stack-vs-heap framing” blockquote lines with different “Last reindex” dates (2026-05-24 vs 2026-05-26). This looks like an unresolved rebase/regen conflict and can cause CI `reindex-memory-md --check` drift or confusing documentation. Keep only the single correct line (likely the latest reindex date) and delete the duplicate. + +### Thread 2: memory/MEMORY.md:120 (resolved) + +**@copilot-pull-request-reviewer** (2026-05-26T18:24:42Z): + +P0: The auto-index footer contains two `_Stack truncated at 100 most-recent entries..._` lines with different heap counts (1331 and 1338). The auto-index contract expects a single sentinel line; this duplication is likely from a merge conflict and can break the generated-index drift check. Remove the older duplicate and keep only one footer line consistent with the reindex run. + +## General comments + +### @chatgpt-codex-connector (2026-05-26T18:22:03Z) + +You have reached your Codex usage limits for code reviews. You can see your limits in the [Codex usage dashboard](https://chatgpt.com/codex/cloud/settings/usage).