From 57d265e6c3149bf816c62e85122f34a322945f38 Mon Sep 17 00:00:00 2001 From: Lior Date: Tue, 26 May 2026 16:17:19 -0400 Subject: [PATCH] docs(archive): Preserve PR #5276 --- ...itive-information-and-fix-schema-errors.md | 61 +++++++++++++++++++ 1 file changed, 61 insertions(+) create mode 100644 docs/pr-discussions/PR-5276-fix-4737-remove-sensitive-information-and-fix-schema-errors.md diff --git a/docs/pr-discussions/PR-5276-fix-4737-remove-sensitive-information-and-fix-schema-errors.md b/docs/pr-discussions/PR-5276-fix-4737-remove-sensitive-information-and-fix-schema-errors.md new file mode 100644 index 0000000000..aeccba4fe3 --- /dev/null +++ b/docs/pr-discussions/PR-5276-fix-4737-remove-sensitive-information-and-fix-schema-errors.md @@ -0,0 +1,61 @@ +--- +pr_number: 5276 +title: "fix(4737): remove sensitive information and fix schema errors (rebased)" +author: "AceHack" +state: "MERGED" +created_at: "2026-05-26T18:25:17Z" +merged_at: "2026-05-26T19:11:40Z" +closed_at: "2026-05-26T19:11:40Z" +head_ref: "lior/fix-4824-conflicts" +base_ref: "main" +archived_at: "2026-05-26T20:17:11Z" +archive_tool: "tools/pr-preservation/archive-pr.ts" +--- + +# PR #5276: fix(4737): remove sensitive information and fix schema errors (rebased) + +## PR description + +This PR supersedes #4737 and #4824. It removes sensitive personal information and fixes schema errors. The conflicts with main have been resolved. + +## Reviews + +### COMMENTED — @copilot-pull-request-reviewer (2026-05-26T18:27:22Z) + +## Pull request overview + +This PR supersedes #4737 and #4824 by removing sensitive personal-information artifacts from `memory/` and attempting to reconcile memory index/schema drift after rebasing. + +**Changes:** +- Deletes two memory artifacts containing sensitive disclosures (one persona conversation substrate file and one feedback memory file). +- Updates `memory/MEMORY.md` to reflect a reindex/new entries, but currently leaves duplicate header/footer metadata that appears to be unresolved reindex/merge drift. + +### Reviewed changes + +Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments. + +| File | Description | +| ---- | ----------- | +| memory/persona/riven/conversations/2026-05-22-aaron-riven-full-session-substrate-trajectory.md | Removed the full-session substrate trajectory file (sensitive-content removal). | +| memory/feedback_aaron_family_configuration_cooperative_substrate_2026_05_22.md | Removed the feedback memory file (sensitive-content removal). | +| memory/MEMORY.md | Reindex/header/footer updates, but introduces duplicate “Last reindex” and duplicated stack-truncation footer lines. | + +## Review threads + +### Thread 1: memory/MEMORY.md:5 (resolved) + +**@copilot-pull-request-reviewer** (2026-05-26T18:27:22Z): + +P0: `memory/MEMORY.md` currently contains two identical Stack-vs-heap framing blockquote lines with different `Last reindex` dates (2026-05-24 vs 2026-05-26). This looks like unresolved merge/reindex drift and will likely fail the repo’s generated-index drift checks. Regenerate via `tools/memory/reindex-memory-md.ts` (or remove the stale duplicate so only the current `Last reindex` line remains). + +### Thread 2: memory/MEMORY.md:118 (resolved) + +**@copilot-pull-request-reviewer** (2026-05-26T18:27:22Z): + +P0: The auto-index footer sentinel is duplicated: there are two `_Stack truncated at 100 most-recent entries..._` lines with different heap counts (1331 vs 1338). The index should have a single sentinel/footer with a single authoritative heap count; regenerate the index (or delete the stale duplicate) to avoid auto-index contract/CI drift failures. + +## General comments + +### @chatgpt-codex-connector (2026-05-26T18:25:21Z) + +You have reached your Codex usage limits for code reviews. You can see your limits in the [Codex usage dashboard](https://chatgpt.com/codex/cloud/settings/usage).