From 43742f49755dd89c6658adc651a9cd3ff603e613 Mon Sep 17 00:00:00 2001 From: Aaron Stainback Date: Thu, 21 May 2026 07:55:25 -0400 Subject: [PATCH] docs(archive): Lior PR preservation for #4526 and #4525 --- ...-correct-5-grandfathered-links-in-1436z.md | 68 +++++++++++++++++ ...-correct-3-grandfathered-links-in-0329z.md | 74 +++++++++++++++++++ 2 files changed, 142 insertions(+) create mode 100644 docs/pr-discussions/PR-4525-fix-tick-shard-paths-correct-5-grandfathered-links-in-1436z.md create mode 100644 docs/pr-discussions/PR-4526-fix-tick-shard-paths-correct-3-grandfathered-links-in-0329z.md diff --git a/docs/pr-discussions/PR-4525-fix-tick-shard-paths-correct-5-grandfathered-links-in-1436z.md b/docs/pr-discussions/PR-4525-fix-tick-shard-paths-correct-5-grandfathered-links-in-1436z.md new file mode 100644 index 0000000000..ae5a2c4b1c --- /dev/null +++ b/docs/pr-discussions/PR-4525-fix-tick-shard-paths-correct-5-grandfathered-links-in-1436z.md @@ -0,0 +1,68 @@ +--- +pr_number: 4525 +title: "fix(tick-shard-paths): correct 5 grandfathered links in 1436Z.md + trim baseline" +author: "AceHack" +state: "MERGED" +created_at: "2026-05-21T11:26:25Z" +merged_at: "2026-05-21T11:29:26Z" +closed_at: "2026-05-21T11:29:26Z" +head_ref: "fix/grandfathered-tick-shard-paths-1436z-2026-05-21" +base_ref: "main" +archived_at: "2026-05-21T11:55:06Z" +archive_tool: "tools/pr-preservation/archive-pr.ts" +--- + +# PR #4525: fix(tick-shard-paths): correct 5 grandfathered links in 1436Z.md + trim baseline + +## PR description + +## Summary + +Slow-steady audit-baseline cleanup, post PR #4524. 1436Z.md is at `docs/hygiene-history/ticks/2026/05/15/` (6 levels deep), so links to sibling top-level dirs need: + +- 5 `..` for `docs/backlog/` (sibling of `hygiene-history` under `docs/`) +- 6 `..` for `.claude/rules/` (sibling of `docs/`) + +All 5 grandfathered links had one `..` too few — same bug class as PR #4524 (0822Z.md) and the PR #4523-fix-commit cycle (1019Z.md). + +## Fixes + +- Line 6: 4× `backlog/` links: 4 `..` → 5 `..` +- Line 30: 1× `.claude/rules/` link: 5 `..` → 6 `..` +- Line 36: 2× `backlog/` links: 4 `..` → 5 `..` + +## Baseline trim + +5 entries for 1436Z.md removed from `tools/hygiene/audit-tick-shard-relative-paths.baseline.json` (39 → 34 entries; some pre-existing entries refer to files already fixed elsewhere — separate cleanup). + +Local audit: `scanned 1137 tick shards; 14 broken relative-path links (14 grandfathered by baseline, 0 new)`. Down from 19 grandfathered post-#4524. + +## Test plan + +- [x] Local `audit-tick-shard-relative-paths.ts --enforce --baseline` reports 0 new findings +- [x] Substrate unchanged (only relative-path depth corrected; prose identical) +- [x] Same bug-class as my prior 2 PRs (#4523 commit + #4524) — pattern is the docs/hygiene-history/ticks/YYYY/MM/DD/ depth being underestimated when authoring shards from inside the dir + +🤖 Generated with [Claude Code](https://claude.com/claude-code) + +## Reviews + +### COMMENTED — @copilot-pull-request-reviewer (2026-05-21T11:29:04Z) + +## Pull request overview + +This PR continues the post-#4524 tick-shard path-audit cleanup by fixing incorrect relative link depths in a deep tick shard (`docs/hygiene-history/ticks/2026/05/15/1436Z.md`) and trimming the corresponding grandfathered entries from the relative-path audit baseline. + +**Changes:** +- Correct `docs/backlog/**` relative links in `1436Z.md` from 4× `..` to 5× `..` (properly reaching `docs/` before `backlog/`). +- Correct the `.claude/rules/**` relative link in `1436Z.md` from 5× `..` to 6× `..` (properly reaching repo root before `.claude/`). +- Remove the 5 now-fixed findings for `1436Z.md` from `tools/hygiene/audit-tick-shard-relative-paths.baseline.json`. + +### Reviewed changes + +Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments. + +| File | Description | +| ---- | ----------- | +| docs/hygiene-history/ticks/2026/05/15/1436Z.md | Fixes relative link depths for `docs/backlog/**` and `.claude/rules/**` targets at this shard’s directory depth. | +| tools/hygiene/audit-tick-shard-relative-paths.baseline.json | Drops baseline entries that correspond to the fixed links in `1436Z.md`. | diff --git a/docs/pr-discussions/PR-4526-fix-tick-shard-paths-correct-3-grandfathered-links-in-0329z.md b/docs/pr-discussions/PR-4526-fix-tick-shard-paths-correct-3-grandfathered-links-in-0329z.md new file mode 100644 index 0000000000..93f9b3f63f --- /dev/null +++ b/docs/pr-discussions/PR-4526-fix-tick-shard-paths-correct-3-grandfathered-links-in-0329z.md @@ -0,0 +1,74 @@ +--- +pr_number: 4526 +title: "fix(tick-shard-paths): correct 3 grandfathered links in 0329Z.md + trim baseline" +author: "AceHack" +state: "MERGED" +created_at: "2026-05-21T11:42:32Z" +merged_at: "2026-05-21T11:46:48Z" +closed_at: "2026-05-21T11:46:48Z" +head_ref: "fix/grandfathered-tick-shard-paths-0329z-2026-05-21" +base_ref: "main" +archived_at: "2026-05-21T11:55:05Z" +archive_tool: "tools/pr-preservation/archive-pr.ts" +--- + +# PR #4526: fix(tick-shard-paths): correct 3 grandfathered links in 0329Z.md + trim baseline + +## PR description + +## Summary + +Slow-steady audit-baseline cleanup, batch 2 (post #4525). 0329Z.md at `docs/hygiene-history/ticks/2026/05/15/` (6 levels deep from repo root) had 3 grandfathered `docs/backlog/` links with 4 `..` instead of 5. Same one-too-few-`..` bug class as #4523/#4524/#4525. + +## Fixes + +- Line 6: `backlog/P3/B-0519-...md`: 4 `..` → 5 `..` +- Line 7: `backlog/P3/B-0528-...md`: 4 `..` → 5 `..` +- Line 20: `backlog/P3/B-0528-...md`: 4 `..` → 5 `..` + +## Baseline trim + +3 entries for 0329Z.md removed (34 → 31). Local audit: `scanned 1137 tick shards; 11 broken relative-path links (11 grandfathered by baseline, 0 new)`. Down from 14 grandfathered post-#4525. + +## Test plan + +- [x] Local `audit-tick-shard-relative-paths.ts --enforce --baseline` reports 0 new findings +- [x] Substrate unchanged (only relative-path depth corrected; prose identical) +- [x] Pattern matches the broader cluster; continuing slow-steady cleanup + +🤖 Generated with [Claude Code](https://claude.com/claude-code) + +## Reviews + +### COMMENTED — @copilot-pull-request-reviewer (2026-05-21T11:44:22Z) + +## Pull request overview + +This PR continues the tick-shard relative-path audit cleanup by correcting broken `docs/backlog/**` links in a specific tick shard and trimming the corresponding grandfathered entries from the audit baseline. + +**Changes:** +- Fixes three `docs/backlog/**` relative links in `docs/hygiene-history/ticks/2026/05/15/0329Z.md` by adding the missing `..` segment. +- Removes the now-fixed findings for `0329Z.md` from `tools/hygiene/audit-tick-shard-relative-paths.baseline.json`. + +### Reviewed changes + +Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment. + +| File | Description | +| ---- | ----------- | +| docs/hygiene-history/ticks/2026/05/15/0329Z.md | Updates three `docs/backlog/**` relative links to the correct depth. | +| tools/hygiene/audit-tick-shard-relative-paths.baseline.json | Trims baseline entries corresponding to the fixed links in `0329Z.md`. | + +## Review threads + +### Thread 1: docs/hygiene-history/ticks/2026/05/15/0329Z.md:7 (resolved) + +**@copilot-pull-request-reviewer** (2026-05-21T11:44:21Z): + +The two backlog-related bullets (B-0519/B-0528) are no longer nested under the preceding “PR #3342” bullet; they’re now top-level list items. This changes the shard’s structure and contradicts the PR description’s claim that only relative-path depth was corrected. Suggest restoring the original nesting/indentation while keeping the updated ../../../../../backlog/... targets. + +## General comments + +### @AceHack (2026-05-21T11:46:43Z) + +@copilot-pull-request-reviewer FP: verified via `git show` against main `555623234` that all 4 "Headline" bullets (lines 5/6/7/8) were top-level peers WITH NO NESTING before the edit, and remain so after. The `replace_all` Edit only changed the relative-path depth (4 `..` → 5 `..`); markdown structure unchanged. The PR description's claim is accurate.