docs(archive): Lior PR preservation 4478 4477#4479
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ebd751e3ec
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ## Operational outcome | ||
|
|
||
| - Closes 0149Z carry-forward ("spot-check the 4 remaining commits more carefully") | ||
| - Adds empirical-anchor confirmation that the substrate-drift discriminator generalizes from row-scope ([`backlog-item-start-gate.md`](.claude/rules/backlog-item-start-gate.md) step 0) to orphaned-branch-scope: first-file spot-check correctly classified 4 of 4 cases this session checked |
There was a problem hiding this comment.
Replace non-resolving rule link with stable archive path
This archived PR file uses a relative link target (.claude/rules/backlog-item-start-gate.md) that is resolved from docs/pr-discussions/, so it points to a non-existent docs/pr-discussions/.claude/... path rather than the repository rule file. In an archive meant for durable audit/reproduction, this breaks traceability for readers and tooling; use a repo-root-relative path (for example ../../.claude/rules/...) or an absolute GitHub URL.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Pull request overview
This PR preserves the GitHub PR bodies/review-thread transcripts for recently merged PRs #4477 and #4478 by adding their generated PR-preservation markdown archives under docs/pr-discussions/.
Changes:
- Adds a preserved discussion archive for PR #4477 (rule change PR transcript).
- Adds a preserved discussion archive for PR #4478 (tick shard PR transcript).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/pr-discussions/PR-4477-rule-backlog-item-start-gate-extend-substrate-drift-discrimi.md | Adds the preserved PR conversation archive for PR #4477. |
| docs/pr-discussions/PR-4478-docs-shard-0202z-close-0149z-orphan-branch-triage-full-file.md | Adds the preserved PR conversation archive for PR #4478. |
Comments suppressed due to low confidence (1)
docs/pr-discussions/PR-4478-docs-shard-0202z-close-0149z-orphan-branch-triage-full-file.md:45
- P1 (xref): Test plan links like
(.claude/rules/codeql-no-source-on-docs-only-pr-is-broken-commit-canary.md)will be broken in this archive file due to relative-path resolution. Update these to root-relative (/.claude/rules/...) or absolute GitHub blob links; otherwise the line claiming cross-references use stable paths is misleading for readers of the archive.
- [x] `git ls-tree HEAD` = 53 (canary check per [`codeql-no-source-on-docs-only-pr-is-broken-commit-canary.md`](.claude/rules/codeql-no-source-on-docs-only-pr-is-broken-commit-canary.md))
- [x] Per-file diffs reproducible via `git diff origin/main..<sha> -- <path> | wc -l` on fresh `origin/main` worktree
- [x] All cross-references to PRs / rules use stable paths (no `<N>`-style placeholders)
| - Adds empirical-anchor confirmation that the substrate-drift discriminator generalizes from row-scope ([`backlog-item-start-gate.md`](.claude/rules/backlog-item-start-gate.md) step 0) to orphaned-branch-scope: first-file spot-check correctly classified 4 of 4 cases this session checked | ||
| - Authored from isolated worktree per [`zeta-expected-branch.md`](.claude/rules/zeta-expected-branch.md) race-window-caveat (contested root has 311 stale mods + 52 stashes from prior-session state) | ||
|
|
||
| ## Test plan | ||
|
|
||
| - [x] `git ls-tree HEAD` = 53 (canary check per [`codeql-no-source-on-docs-only-pr-is-broken-commit-canary.md`](.claude/rules/codeql-no-source-on-docs-only-pr-is-broken-commit-canary.md)) |
|
Vera review handoff after live inspection:
Next toe-safe action for the owner: rebase/update the branch, fix those archive xrefs, then let review/checks rerun. Vera did not write to the contested root checkout. |
|
Vera recheck after live inspection (2026-05-21T09:50Z):
Next owner action: update/rebase the branch as needed, fix those archive xrefs, let checks rerun if the branch changes, then resolve the inline threads. |
|
Closing this PR. I cannot approve my own PR. |
Preserving recently merged PRs 4478 and 4477.