Skip to content

docs(archive): Lior PR preservation 4478 4477#4479

Closed
AceHack wants to merge 1 commit into
mainfrom
lior/preserve-4478-4477
Closed

docs(archive): Lior PR preservation 4478 4477#4479
AceHack wants to merge 1 commit into
mainfrom
lior/preserve-4478-4477

Conversation

@AceHack
Copy link
Copy Markdown
Member

@AceHack AceHack commented May 21, 2026

Preserving recently merged PRs 4478 and 4477.

Copilot AI review requested due to automatic review settings May 21, 2026 02:18
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ebd751e3ec

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

## Operational outcome

- Closes 0149Z carry-forward ("spot-check the 4 remaining commits more carefully")
- Adds empirical-anchor confirmation that the substrate-drift discriminator generalizes from row-scope ([`backlog-item-start-gate.md`](.claude/rules/backlog-item-start-gate.md) step 0) to orphaned-branch-scope: first-file spot-check correctly classified 4 of 4 cases this session checked
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Replace non-resolving rule link with stable archive path

This archived PR file uses a relative link target (.claude/rules/backlog-item-start-gate.md) that is resolved from docs/pr-discussions/, so it points to a non-existent docs/pr-discussions/.claude/... path rather than the repository rule file. In an archive meant for durable audit/reproduction, this breaks traceability for readers and tooling; use a repo-root-relative path (for example ../../.claude/rules/...) or an absolute GitHub URL.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR preserves the GitHub PR bodies/review-thread transcripts for recently merged PRs #4477 and #4478 by adding their generated PR-preservation markdown archives under docs/pr-discussions/.

Changes:

  • Adds a preserved discussion archive for PR #4477 (rule change PR transcript).
  • Adds a preserved discussion archive for PR #4478 (tick shard PR transcript).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
docs/pr-discussions/PR-4477-rule-backlog-item-start-gate-extend-substrate-drift-discrimi.md Adds the preserved PR conversation archive for PR #4477.
docs/pr-discussions/PR-4478-docs-shard-0202z-close-0149z-orphan-branch-triage-full-file.md Adds the preserved PR conversation archive for PR #4478.
Comments suppressed due to low confidence (1)

docs/pr-discussions/PR-4478-docs-shard-0202z-close-0149z-orphan-branch-triage-full-file.md:45

  • P1 (xref): Test plan links like (.claude/rules/codeql-no-source-on-docs-only-pr-is-broken-commit-canary.md) will be broken in this archive file due to relative-path resolution. Update these to root-relative (/.claude/rules/...) or absolute GitHub blob links; otherwise the line claiming cross-references use stable paths is misleading for readers of the archive.
- [x] `git ls-tree HEAD` = 53 (canary check per [`codeql-no-source-on-docs-only-pr-is-broken-commit-canary.md`](.claude/rules/codeql-no-source-on-docs-only-pr-is-broken-commit-canary.md))
- [x] Per-file diffs reproducible via `git diff origin/main..<sha> -- <path> | wc -l` on fresh `origin/main` worktree
- [x] All cross-references to PRs / rules use stable paths (no `<N>`-style placeholders)

Comment on lines +38 to +43
- Adds empirical-anchor confirmation that the substrate-drift discriminator generalizes from row-scope ([`backlog-item-start-gate.md`](.claude/rules/backlog-item-start-gate.md) step 0) to orphaned-branch-scope: first-file spot-check correctly classified 4 of 4 cases this session checked
- Authored from isolated worktree per [`zeta-expected-branch.md`](.claude/rules/zeta-expected-branch.md) race-window-caveat (contested root has 311 stale mods + 52 stashes from prior-session state)

## Test plan

- [x] `git ls-tree HEAD` = 53 (canary check per [`codeql-no-source-on-docs-only-pr-is-broken-commit-canary.md`](.claude/rules/codeql-no-source-on-docs-only-pr-is-broken-commit-canary.md))
@AceHack
Copy link
Copy Markdown
Member Author

AceHack commented May 21, 2026

Vera review handoff after live inspection:

  • Current head ebd751e3ecf226da4303b93bae040d10cf88f574 is owner-only (maintainerCanModify=false).
  • Checks are green: build/test, markdownlint, CodeQL, and Agent all completed successfully.
  • Base is stale: PR base 68dc73f930679193ff5c7b3b64791ffe25464a05; current origin/main is 51f4cde30d9b07e6a4ed0d7e31d0a55519420f7c.
  • Live review blockers are broken .claude/rules/** relative links in docs/pr-discussions/PR-4478-docs-shard-0202z-close-0149z-orphan-branch-triage-full-file.md:
    • Codex comment line 38: (.claude/rules/backlog-item-start-gate.md) resolves under docs/pr-discussions/ and should be root-relative, e.g. /.claude/rules/backlog-item-start-gate.md, or a full GitHub blob URL.
    • Copilot comment line 43, also applies line 43: .claude/rules/... links should be repo-root-relative or full blob URLs.

Next toe-safe action for the owner: rebase/update the branch, fix those archive xrefs, then let review/checks rerun. Vera did not write to the contested root checkout.

@AceHack
Copy link
Copy Markdown
Member Author

AceHack commented May 21, 2026

Vera recheck after live inspection (2026-05-21T09:50Z):

  • Current head is ebd751e3ecf226da4303b93bae040d10cf88f574; PR base is still 68dc73f930679193ff5c7b3b64791ffe25464a05, while current main is now 883fed98f315dc455d257027d53c81691b3953d2. The earlier handoff's current-main SHA is stale.
  • maintainerCanModify=false, so Vera did not edit the owner branch or use the contested root checkout.
  • Visible checks remain green. GitHub GraphQL reports mergeable=MERGEABLE, but two unresolved review threads remain on docs/pr-discussions/PR-4478-docs-shard-0202z-close-0149z-orphan-branch-triage-full-file.md.
  • Live blockers remain broken .claude/rules/** relative links: line 38 should replace (.claude/rules/backlog-item-start-gate.md) with a repo-root-relative or full GitHub blob URL; line 43 has the same .claude/rules/... archive-link issue.

Next owner action: update/rebase the branch as needed, fix those archive xrefs, let checks rerun if the branch changes, then resolve the inline threads.

@AceHack
Copy link
Copy Markdown
Member Author

AceHack commented May 22, 2026

Closing this PR. I cannot approve my own PR.

@AceHack AceHack closed this May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants