From 220e6cdf7c2d0870d7c6baa939756f499e4d07f9 Mon Sep 17 00:00:00 2001 From: Aaron Stainback Date: Fri, 15 May 2026 16:21:09 -0400 Subject: [PATCH] fix(otto-279): role-refs in tools/github/test + tools/peer-call (2 hits) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Otto-279 cleanup batch #4. Same fix pattern as batches #1-#3 (PRs #3570, #3572, #3574). Files: - tools/github/poll-pr-gate-batch.test.ts:9 — `Per Aaron 2026-05-01` → `Per the human maintainer 2026-05-01` - tools/peer-call/append-identity-receipt.ts:307 — `Per Copilot 2026-05-06 review on PR #1702` → `Per PR #1702 review 2026-05-06` Verbatim quote content preserved in both cases. Auditor verification: `bun tools/hygiene/audit-orphan-role-refs.ts` re-run shows 0 hits in target scope after fix. Remaining (next-batch candidates): - src/Core/Maji.fs + tests + tools/hygiene/audit-agencysignature-main-tip.ts + tools/hygiene/validate-agencysignature-pr-body.ts + docs/trajectories/.../slice-audits.md — `orphan-ferry-ref` class (different fix pattern — requires per-occurrence judgment) Composes with: PR #3570 (.claude/), PR #3572 (docs/), PR #3574 (tools/hygiene/audit-*.ts), tools/hygiene/audit-orphan-role-refs.ts, Otto-279 carve-out. Co-Authored-By: Claude Opus 4.7 (1M context) --- tools/github/poll-pr-gate-batch.test.ts | 4 ++-- tools/peer-call/append-identity-receipt.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/github/poll-pr-gate-batch.test.ts b/tools/github/poll-pr-gate-batch.test.ts index 5f0df6f39..a6040aa91 100644 --- a/tools/github/poll-pr-gate-batch.test.ts +++ b/tools/github/poll-pr-gate-batch.test.ts @@ -6,8 +6,8 @@ // across runs because every input is fixed and every random/time source // is excluded by construction. // -// Per Aaron 2026-05-01 (the rule this tool was written to satisfy): -// *"DST is bascically impossible there [in bash], not in ts."* These +// Per the human maintainer 2026-05-01 (the rule this tool was written +// to satisfy): *"DST is bascically impossible there [in bash], not in ts."* These // tests are the worked-example proof that a TS tool ported from a bash // equivalent can carry DST grade-A coverage that the bash form // structurally cannot. diff --git a/tools/peer-call/append-identity-receipt.ts b/tools/peer-call/append-identity-receipt.ts index 2ebfa57c1..7c49e387c 100755 --- a/tools/peer-call/append-identity-receipt.ts +++ b/tools/peer-call/append-identity-receipt.ts @@ -304,7 +304,7 @@ function checkNoCollision(path: string, receiptId: string): void { } function main(): number { - // Per Copilot 2026-05-06 review on PR #1702: parseArgs.next() can + // Per PR #1702 review 2026-05-06: parseArgs.next() can // throw when a flag is missing its value (e.g. `--actor` at end of // argv); catch the throw at main() so the script exits with a // user-friendly error instead of an unhandled-exception traceback.