feat(b-0528): unit tests for shadow launchd installer (6 categories, 19 tests)

[AceHack]

Summary

Closes B-0528 — the deferred test-coverage P1 from PR #3375's review cycle. All 6 acceptance categories covered with 19 tests / 39 expect calls.

Coverage by category

#	Category	Test count
1	Placeholder substitution	3
2	XML escaping (+ integration with substitutePlaceholders + plutil)	4
3	Argument validation (subprocess-driven)	6
4	Dry-run output (subprocess + plutil round-trip)	1
5	Default detection (tryDetect)	3
6	plutilLint safe-path / failure-path	2

Substrate-honest gap note

The availability-preserving install pattern (read-old-into-memory → write-tmp → atomic-rename → side-car-backup) has its SAFE branches covered via dry-run + plutilLint tests. The UNSAFE branches (atomic-rename failure, backup-write failure) require either mocking destPath to a tmpdir or running the actual install and cleaning up — neither is straightforward without refactoring main() to accept a destPath override. Documented in a comment at the bottom of the test file. Filing a follow-up if reviewers flag it.

Verification

• bunx tsc --noEmit clean
• bun test tools/shadow/launchd/install-launchagent.test.ts — 19 pass / 0 fail
• CI green
• Auto-merge fires

🤖 Generated with Claude Code

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c16e9b31db

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[Copilot]

Pull request overview

Adds a Bun unit-test suite for the macOS LaunchAgent “shadow launchd installer” script (tools/shadow/launchd/install-launchagent.ts) to close backlog item B-0528 by covering placeholder substitution, XML escaping, argument validation, dry-run output, default detection, and plutilLint behavior.

Changes:

• Introduces 19 Bun tests covering 6 acceptance categories for the launchd installer helpers and CLI dry-run path.
• Exercises several error/exit paths via subprocess execution to validate exit codes and stderr output.
• Adds integration checks that validate generated plists via plutil -lint.

Comments suppressed due to low confidence (2)

tools/shadow/launchd/install-launchagent.test.ts:183

• P0: This test pipes the --dry-run output to plutil -lint. plutil is macOS-only, so this will fail on Linux/Windows CI or when contributors run bun test outside macOS. Gate/skip the plutil round-trip when process.platform !== "darwin" (and still keep the pure string assertions active).

    const proc = spawnSync(
      "bun",
      [SCRIPT_PATH, "--dry-run", "--repo-root", repoRoot, "--bun-path", bunPath],
      { encoding: "utf-8" },
    );
    expect(proc.status).toBe(0);
    expect(proc.stdout).toContain("<?xml version=\"1.0\"");
    expect(proc.stdout).toContain("<plist version=\"1.0\">");
    expect(proc.stdout).toContain(repoRoot);
    expect(proc.stdout).toContain(bunPath);
    // Verify it's a valid plist by piping to plutil
    const dir = mkdtempSync(join(tmpdir(), "test-dry-run-"));
    const tmp = join(dir, "rendered.plist");
    try {
      writeFileSync(tmp, proc.stdout, "utf-8");
      const lint = spawnSync("plutil", ["-lint", tmp], { encoding: "utf-8" });
      expect(lint.status).toBe(0);

tools/shadow/launchd/install-launchagent.test.ts:235

• P0: plutilLint() calls plutil and process.exit(1) on failure. If plutil is missing (non-macOS), this in-process test will terminate the entire test run rather than just failing an assertion. Please skip/gate the whole plutilLint describe block when process.platform !== "darwin" (or when plutil is not on PATH).

describe("plutilLint", () => {
  it("returns without throwing for a valid plist", () => {
    const valid = `<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0"><dict/></plist>`;
    expect(() => plutilLint(valid)).not.toThrow();
  });