fix(shards): bulk-fix substrate-wide rule-link path-bug in 4 of my tick shards#3382
Closed
AceHack wants to merge 1 commit into
Closed
fix(shards): bulk-fix substrate-wide rule-link path-bug in 4 of my tick shards#3382AceHack wants to merge 1 commit into
AceHack wants to merge 1 commit into
Conversation
…ck shards Substrate-wide path-bug discovered via Copilot review on PR #3376 (tick 0729Z): ../../../../../.claude/rules/X.md from docs/hygiene-history/ticks/YYYY/MM/DD/*.md only climbs to docs/, not repo root. Need 6 dotdot, not 5. Already-merged shards needed fix-up. This PR fixes the 4 of mine in the May 2026 cohort still on origin/main with the bug: - 0414Z.md (6 broken occurrences) - 0517Z.md (3 broken occurrences) - 0524Z.md (2 broken occurrences) - 0717Z.md (1 broken occurrence) Total 12 broken-link occurrences fixed across 4 files via sed s|x5dotdot|x6dotdot|g. Empirical verification: `realpath` from each shard's dir now resolves all rule-file links correctly. Out of scope (lane-respect): peer-Otto's 0230Z + 0615Z shards may also have the bug but are NOT touched here — those are peer-Otto's to fix per lane discipline. Co-Authored-By: Claude <noreply@anthropic.com>
5 tasks
AceHack
added a commit
that referenced
this pull request
May 15, 2026
…ressed; bulk-fix PR #3382 opened (#3383) * shard(tick): 0754Z — PR #3380 merged; Codex P2 thread on PR #3379 addressed; bulk-fix PR #3382 opened PR #3380 (0729Z shard) merged at 151c835. New Codex P2 thread on PR #3379 (0724Z shard) about gh run rerun --failed description (manual says it INCLUDES dependencies, contradicting my prior wording). Corrected in commit ac36bc4; thread resolved. Bulk-fix PR #3382 opened — 12 broken path-bug occurrences across 4 of my shards (0414Z, 0517Z, 0524Z, 0717Z). Lane-respect: peer-Otto's 0230Z + 0615Z untouched. This tick chose to inline-fix rather than file-and-defer because the fix is mechanical + scope is narrow + within authority scope per dont-ask-permission. #2 follow-on (ID-allocation discipline update to otto-channels-reference-card.md) deferred to next tick because that's a shared rule edit with broader blast radius. Co-Authored-By: Claude <noreply@anthropic.com> * fix(shard): replace (PR TBD) placeholder with (PR #3383) — preempts Codex P2 catch Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
Member
Author
|
Superseded —
So 3 of 4 fixes have been integrated by some other bulk-fix that landed before mine. The 4th file's Closing this PR. The Substrate-honest concurrent-Otto lesson: when two Ottos identify the same substrate-wide bug and propose mirror fixes, the faster fix wins. My PR was correct but late. The work isn't wasted — it's substrate confirmation that the bug was real + the fix was right. Closing without merge is the appropriate outcome. |
auto-merge was automatically disabled
May 15, 2026 08:51
Pull request was closed
AceHack
added a commit
that referenced
this pull request
May 15, 2026
…seded (#3392) * shard(tick): 0844Z — PR #3389 2-Copilot fix; PR #3382 closed as superseded by concurrent peer-Otto bulk-fix Co-Authored-By: Claude <noreply@anthropic.com> * fix(shard): close (PR TBD) → (PR #3392) (line-1 anchored sed per 0844Z lesson) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bulk-fixes the substrate-wide rule-link path-bug across 4 of my already-merged tick shards:
12 broken `.claude/rules/X.md` link occurrences total. Bug origin: from `docs/hygiene-history/ticks/YYYY/MM/DD/*.md`, 5 `..` only climbs to `docs/`; 6 `..` is needed for repo root. Discovered via Copilot review on PR #3376 (tick 0729Z) and confirmed empirically via `realpath`.
Out of scope (lane-respect):
Test plan
🤖 Generated with Claude Code