docs(archive): Lior preservation discipline for recently merged PRs#3317
docs(archive): Lior preservation discipline for recently merged PRs#3317AceHack wants to merge 3 commits into
Conversation
…312 3311 3310 3307
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d5d53b57cd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Adds new PR-discussion archive entries under docs/pr-discussions/ for recently merged PRs, extending the repo’s PR-preservation trail.
Changes:
- Added archived PR discussion markdown files for PRs #3312, #3311, #3310, and #3307.
- Captured PR metadata (frontmatter) plus copied PR descriptions and review threads.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| docs/pr-discussions/PR-3312-feat-persona-ani-33-archive-cascade-closing-persona-folder-i.md | Adds PR #3312 discussion archive; includes provenance link that currently points to a non-existent tick shard path. |
| docs/pr-discussions/PR-3311-feat-persona-ani-33-archive-cascade-closing-persona-folder-i.md | Adds PR #3311 discussion archive; contains escaped quotes that render with backslashes. |
| docs/pr-discussions/PR-3310-shard-tick-0004z-0003z-pr-3306-merged-consolidation-sanity-c.md | Adds PR #3310 discussion archive; references tick shard files that aren’t present in-repo. |
| docs/pr-discussions/PR-3307-docs-rules-add-worktree-force-remove-guard-to-claim-acquire.md | Adds PR #3307 discussion archive; contains broken relative links and escaped quotes. |
Comments suppressed due to low confidence (3)
docs/pr-discussions/PR-3307-docs-rules-add-worktree-force-remove-guard-to-claim-acquire.md:25
- The tick-shard citation link is written as
docs/...relative to this file, which produces a broken link, anddocs/hygiene-history/ticks/2026/05/14/1813Z.mdis not present in the repo. Please update the link target (or the cited path) so the empirical anchor is actually navigable.
[docs/hygiene-history/ticks/2026/05/14/1813Z.md](docs/hygiene-history/ticks/2026/05/14/1813Z.md) (Otto-CLI's tick shard) documents:
docs/pr-discussions/PR-3307-docs-rules-add-worktree-force-remove-guard-to-claim-acquire.md:21
- The text contains escaped quotes (
\"…\") which will render the backslashes in Markdown. Replace these with normal quotes so the archive renders cleanly.
Extends [.claude/rules/claim-acquire-before-worktree-work.md](.claude/rules/claim-acquire-before-worktree-work.md) with a new \"Worktree force-remove guard\" section covering an empirical failure mode that the existing rule didn't anticipate.
docs/pr-discussions/PR-3307-docs-rules-add-worktree-force-remove-guard-to-claim-acquire.md:44
- These escaped quotes (
\"When this rule applies\",\"DOES NOT APPLY\") will render with backslashes in Markdown. Please remove the escaping so the prose renders as intended.
- Composes with the existing \"When this rule applies\" / \"DOES NOT APPLY\" framing
…311 archives Two issues from archive-pr.ts not unescaping JSON string content: PR-3307 archive: - \" → " throughout the PR description body - \` → ` throughout (backtick escapes rendering as literal backslashes) - Relative link [.claude/rules/claim-acquire-before-worktree-work.md](.claude/rules/...) → [.claude/rules/claim-acquire-before-worktree-work.md](../../.claude/rules/...) (correct relative path from docs/pr-discussions/ to repo root) PR-3311 archive: - \" → " in Aaron's quoted catch text Resolves copilot unresolved threads 1, 2, 3 on PR #3317. Threads 4 and 5 (tick-shard link) are addressed via reply — those files now exist on main (merged before this archive was created). Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 63b78d1477
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…-3307 archive The empirical-anchor link used docs/hygiene-history/... which from docs/pr-discussions/ resolves to docs/pr-discussions/ adocs/... dead path. Fix to ../hygiene-history/... so the link navigates to the correct repo path. Resolves unresolved Codex review thread on PR #3317. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Closing as substrate-mostly-redundant after per-PR triage (8 days stale, DIRTY): 2 of 4 files byte-identical on origin/main:
2 missing on main (preservation for source PRs that DID merge):
Subsequent Lior preservation runs did not pick these up — likely due to filename-scheme drift or skip-on-conflict. Source PRs are merged; preservation discussions can be re-archived via a fresh Per |
Automated preservation of recently merged PRs 3312 3311 3310 3307 to docs/pr-discussions/.