From 3be7ee5714d8a90134aced97b60eccf564898d78 Mon Sep 17 00:00:00 2001 From: Aaron Stainback Date: Thu, 14 May 2026 14:28:24 -0400 Subject: [PATCH 1/2] fix(policy): add docs/pr-discussions/** to history-surface allowlist docs/AGENT-BEST-PRACTICES.696-697 and tools/pr-preservation/archive-pr.tsmd both use docs/pr-discussions/ as the output directory for PR archives, but .github/copilot-instructions.md only listed docs/pr-preservation/** in its history-surfaces allowlist. This drift would cause Copilot reviews to incorrectly flag attribution in pr-discussions archives as policy violations. Add docs/pr-discussions/** in both occurrences (main list and surface-category quick-reference) to match the authoritative list in AGENT-BEST-PRACTICES.md. Closes thread PRRT_kwDOSF9kNM6CJxHZ on PR #3157. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .github/copilot-instructions.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/copilot-instructions.md b/.github/copilot-instructions.md index d0ec4e0ef8..615ef7d57a 100644 --- a/.github/copilot-instructions.md +++ b/.github/copilot-instructions.md @@ -330,6 +330,7 @@ Per [docs/CONFLICT-RESOLUTION.md](../docs/CONFLICT-RESOLUTION.md) - `docs/DECISIONS/**` — ADRs - `docs/aurora/**` — courier-ferry archive - `docs/pr-preservation/**` — PR conversation archive + - `docs/pr-discussions/**` — PR discussion archive (generated by `tools/pr-preservation/archive-pr.ts`; preserves author attribution as provenance metadata) - `docs/hygiene-history/**` — tick-history + drain-logs - `docs/WINS.md` — historical wins log - commit messages, PR titles + bodies — git-native @@ -391,7 +392,8 @@ Per [docs/CONFLICT-RESOLUTION.md](../docs/CONFLICT-RESOLUTION.md) - **History surfaces** (preserve attribution as-is): `memory/**`, `docs/research/**`, `docs/ROUND-HISTORY.md`, `docs/DECISIONS/**`, `docs/aurora/**`, - `docs/pr-preservation/**`, `docs/hygiene-history/**`, + `docs/pr-preservation/**`, `docs/pr-discussions/**`, + `docs/hygiene-history/**`, `docs/WINS.md`, `docs/BACKLOG.md`, `docs/backlog/**`, commit messages, PR titles + bodies. - **Roster-mapping carve-out** (governance / instructions From 2986a4f8dd255fdd8ae11954b3fcd553ed16c376 Mon Sep 17 00:00:00 2001 From: Aaron Stainback Date: Thu, 14 May 2026 14:38:29 -0400 Subject: [PATCH 2/2] fix(policy): sync copilot-instructions allowlist with AGENT-BEST-PRACTICES Add missing history-surface entries to both allowlist sections in .github/copilot-instructions.md to match the authoritative list in docs/AGENT-BEST-PRACTICES.md lines 694-714: - docs/lost-substrate/** (recovery/redundancy artifacts) - docs/active-trajectory.md (load-state + who-said-what provenance) - docs/launch/** (named-team positioning + IP-respect attribution) Fixes both line 331 (full list) and line 395 (quick-reference) per Copilot P1 review thread on PR #3164. Co-Authored-By: Claude --- .github/copilot-instructions.md | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/copilot-instructions.md b/.github/copilot-instructions.md index 615ef7d57a..8c132a6309 100644 --- a/.github/copilot-instructions.md +++ b/.github/copilot-instructions.md @@ -329,9 +329,12 @@ Per [docs/CONFLICT-RESOLUTION.md](../docs/CONFLICT-RESOLUTION.md) - `docs/ROUND-HISTORY.md` — round-close history - `docs/DECISIONS/**` — ADRs - `docs/aurora/**` — courier-ferry archive + - `docs/lost-substrate/**` — recovery and redundancy artifacts whose job is to preserve what was at risk of being lost - `docs/pr-preservation/**` — PR conversation archive - `docs/pr-discussions/**` — PR discussion archive (generated by `tools/pr-preservation/archive-pr.ts`; preserves author attribution as provenance metadata) - `docs/hygiene-history/**` — tick-history + drain-logs + - `docs/active-trajectory.md` — load-state file + cumulative trajectory log; names + filenames-with-names are first-class here because the file's job is to preserve who-said-what + per-file named evidence + - `docs/launch/**` — launch substrate (public-facing positioning artifacts; persona names + external creator attributions allowed because the substrate's job is to preserve the multi-agent factory's named-team positioning AND IP-respect attribution) - `docs/WINS.md` — historical wins log - commit messages, PR titles + bodies — git-native history (record-of-truth, not factory docs) @@ -392,9 +395,10 @@ Per [docs/CONFLICT-RESOLUTION.md](../docs/CONFLICT-RESOLUTION.md) - **History surfaces** (preserve attribution as-is): `memory/**`, `docs/research/**`, `docs/ROUND-HISTORY.md`, `docs/DECISIONS/**`, `docs/aurora/**`, - `docs/pr-preservation/**`, `docs/pr-discussions/**`, - `docs/hygiene-history/**`, + `docs/lost-substrate/**`, `docs/pr-preservation/**`, + `docs/pr-discussions/**`, `docs/hygiene-history/**`, `docs/WINS.md`, `docs/BACKLOG.md`, `docs/backlog/**`, + `docs/active-trajectory.md`, `docs/launch/**`, commit messages, PR titles + bodies. - **Roster-mapping carve-out** (governance / instructions files where a one-time persona-to-role mapping section