From b8859cbeab030dfedf920bd44cd67ce8520bcbe9 Mon Sep 17 00:00:00 2001 From: Aaron Stainback Date: Wed, 13 May 2026 20:55:25 -0400 Subject: [PATCH] docs: archive PRs 3073, 3070, 3069 --- ...b-0410-b-0411-collisions-renumber-amara.md | 86 +++++++ ...er-stale-slice-5-follow-up-reservations.md | 41 +++ ...b-0409-3-way-collision-completes-b-0451.md | 237 ++++++++++++++++++ 3 files changed, 364 insertions(+) create mode 100644 docs/pr-discussions/PR-3069-fix-backlog-resolve-b-0410-b-0411-collisions-renumber-amara.md create mode 100644 docs/pr-discussions/PR-3070-fix-b-0449-renumber-stale-slice-5-follow-up-reservations.md create mode 100644 docs/pr-discussions/PR-3073-fix-backlog-resolve-b-0409-3-way-collision-completes-b-0451.md diff --git a/docs/pr-discussions/PR-3069-fix-backlog-resolve-b-0410-b-0411-collisions-renumber-amara.md b/docs/pr-discussions/PR-3069-fix-backlog-resolve-b-0410-b-0411-collisions-renumber-amara.md new file mode 100644 index 0000000000..1423af05c3 --- /dev/null +++ b/docs/pr-discussions/PR-3069-fix-backlog-resolve-b-0410-b-0411-collisions-renumber-amara.md @@ -0,0 +1,86 @@ +--- +pr_number: 3069 +title: "fix(backlog): resolve B-0410-B-0411 collisions \u2014 renumber amara series \u2192 B-0457-B-0458" +author: "AceHack" +state: "MERGED" +created_at: "2026-05-14T00:12:18Z" +merged_at: "2026-05-14T00:15:04Z" +closed_at: "2026-05-14T00:15:04Z" +head_ref: "fix/b0410-b0411-id-collision-renumber-amara-series-to-b0457-b0458-2026-05-14" +base_ref: "main" +archived_at: "2026-05-14T00:55:19Z" +archive_tool: "tools/pr-preservation/archive-pr.ts" +--- + +# PR #3069: fix(backlog): resolve B-0410-B-0411 collisions — renumber amara series → B-0457-B-0458 + +## PR description + +## Summary + +Fourth per-collision cleanup from the [B-0451](docs/backlog/P1/B-0451-duplicate-row-id-substrate-cleanup-2026-05-13.md) sweep. B-0410 + B-0411 form one connected component (amara series: B-0411 depends on B-0410). + +## The collisions + +| ID | B-0118 amara series ([#2704](https://github.com/Lucent-Financial-Group/Zeta/pull/2704)) | B-0120 peer-call series ([#2706](https://github.com/Lucent-Financial-Group/Zeta/pull/2706)) | +|---|---|---| +| B-0410 | amara.ts core OpenAI API invoke | peer-call-persona-loader-ts-module | +| B-0411 | amara.ts README + courier-debt | grok-ts-persona-flag-impl | + +## Resolution: keep B-0120 (peer-call) series + +Per external-references rule: + +- B-0120 parent's frontmatter lists `children: [B-0410, B-0411]` AND `depends_on: [B-0410, B-0411]` — strong references +- B-0412 (`codex-gemini-ts-persona-flag-impl`) `depends_on: [B-0411]` with body referring to grok-ts integration — refers to peer-call series +- B-0118 parent only has body-text mentions (editable here) + +→ Keep B-0120's children at B-0410/B-0411. Renumber amara series: + +``` +B-0410 → B-0457 (amara.ts core) +B-0411 → B-0458 (amara.ts README + closure) +``` + +## Empirical effect + +| Signal | Before | After | +|---|---|---| +| Duplicate-ID groups | 3 | 1 | + +[B-0451](docs/backlog/P1/B-0451-duplicate-row-id-substrate-cleanup-2026-05-13.md) cleanup progress: **9/12 → 11/12**. Only B-0409 3-way remains for future-Otto. + +## Test plan + +- [x] `git mv` preserves history +- [x] Internal `depends_on` chain remapped (B-0458 → B-0457) +- [x] B-0118 parent body updated to new IDs +- [x] `BACKLOG_WRITE_FORCE=1 bun tools/backlog/generate-index.ts` regenerated +- [x] `bun tools/bg/audit-duplicate-row-ids.ts` confirms 3 → 1 +- [x] Worktree-isolated build (`/tmp/zeta-b0410-b0411-fix`) + +🤖 Generated with [Claude Code](https://claude.com/claude-code) + +## Reviews + +### COMMENTED — @copilot-pull-request-reviewer (2026-05-14T00:13:47Z) + +## Pull request overview + +Fourth per-collision cleanup from the B-0451 sweep: renumbers the amara series (B-0410/B-0411) to B-0457/B-0458 to resolve duplicate-ID collisions with B-0120's children (peer-call persona-loader / grok-ts persona flag). The peer-call series is kept at B-0410/B-0411 because B-0120's frontmatter and B-0412 hold stronger external references. + +**Changes:** +- Renumber `B-0410` → `B-0457` (amara.ts core) and `B-0411` → `B-0458` (amara.ts README + closure), with `renumbered_from` / `renumbered_reason` frontmatter and remapped internal `depends_on` (B-0458 → B-0457). +- Update B-0118 parent body to point at new child IDs and add note about the renumber. +- Regenerate `docs/BACKLOG.md` so the amara rows appear at B-0457/B-0458 and the duplicate B-0410/B-0411 lines are dropped. + +### Reviewed changes + +Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments. + +| File | Description | +| ---- | ----------- | +| docs/backlog/P2/B-0457-amara-ts-core-openai-api-invoke-flag-parity-ts-first-riven-2026-05-11.md | Renames id to B-0457, bumps last_updated, adds renumbered_from/reason and tag. | +| docs/backlog/P2/B-0458-amara-ts-readme-update-courier-debt-closure-test-invoke-ts-first-riven-2026-05-11.md | Renames id to B-0458, remaps depends_on/composes_with to B-0457, adds renumber metadata. | +| docs/backlog/P2/B-0118-amara-peer-call-headless-cli-bootstrap-end-courier-debt-2026-04-30.md | Updates parent index/status notes to reference new child IDs. | +| docs/BACKLOG.md | Removes old B-0410/B-0411 amara entries; adds B-0457/B-0458 entries. | diff --git a/docs/pr-discussions/PR-3070-fix-b-0449-renumber-stale-slice-5-follow-up-reservations.md b/docs/pr-discussions/PR-3070-fix-b-0449-renumber-stale-slice-5-follow-up-reservations.md new file mode 100644 index 0000000000..222dec9388 --- /dev/null +++ b/docs/pr-discussions/PR-3070-fix-b-0449-renumber-stale-slice-5-follow-up-reservations.md @@ -0,0 +1,41 @@ +--- +pr_number: 3070 +title: "fix(B-0449): renumber stale slice-5 follow-up reservations" +author: "AceHack" +state: "MERGED" +created_at: "2026-05-14T00:18:20Z" +merged_at: "2026-05-14T00:19:52Z" +closed_at: "2026-05-14T00:19:52Z" +head_ref: "fix/b0449-stale-slot-reservation-renumber-2026-05-14" +base_ref: "main" +archived_at: "2026-05-14T00:55:17Z" +archive_tool: "tools/pr-preservation/archive-pr.ts" +--- + +# PR #3070: fix(B-0449): renumber stale slice-5 follow-up reservations + +## PR description + +Aspirational slot reservations in B-0449 (B-0450/0451/0452) were allocated by the 2026-05-13 collision-renumber cascade. Renumbering to next-available B-0459/0460/0461. Substrate-honesty maintenance. + +🤖 Generated with [Claude Code](https://claude.com/claude-code) + +## Reviews + +### COMMENTED — @copilot-pull-request-reviewer (2026-05-14T00:20:14Z) + +## Pull request overview + +Renumbers the slice-5 follow-up reservations in B-0449 from B-0450/0451/0452 (which were claimed by a 2026-05-13 collision-renumber cascade) to the next-available IDs B-0459/0460/0461, with an explanatory note documenting the reservation history. + +**Changes:** +- Updates the three follow-up row IDs in the per-topic handler list to B-0459/0460/0461 +- Adds a parenthetical history note explaining the original B-0450/0451/0452 reservations and where those slots were actually allocated + +## Review threads + +### Thread 1: docs/backlog/P1/B-0449-bg-services-slice-5-subscriber-agent-design-pass-2026-05-13.md:145 (unresolved) + +**@copilot-pull-request-reviewer** (2026-05-14T00:20:14Z): + +The `last_updated` frontmatter field on this row is still `2026-05-13` despite this PR editing the content. Per `tools/backlog/README.md`, `last_updated` must be updated on every content edit; bump it to today's date (2026-05-14). diff --git a/docs/pr-discussions/PR-3073-fix-backlog-resolve-b-0409-3-way-collision-completes-b-0451.md b/docs/pr-discussions/PR-3073-fix-backlog-resolve-b-0409-3-way-collision-completes-b-0451.md new file mode 100644 index 0000000000..3039dfbdc9 --- /dev/null +++ b/docs/pr-discussions/PR-3073-fix-backlog-resolve-b-0409-3-way-collision-completes-b-0451.md @@ -0,0 +1,237 @@ +--- +pr_number: 3073 +title: "fix(backlog): resolve B-0409 3-way collision \u2014 completes B-0451 substrate-hygiene sweep" +author: "AceHack" +state: "MERGED" +created_at: "2026-05-14T00:20:55Z" +merged_at: "2026-05-14T00:39:35Z" +closed_at: "2026-05-14T00:39:35Z" +head_ref: "fix/b0409-3way-collision-renumber-amara-and-wallet-2026-05-14" +base_ref: "main" +archived_at: "2026-05-14T00:55:16Z" +archive_tool: "tools/pr-preservation/archive-pr.ts" +--- + +# PR #3073: fix(backlog): resolve B-0409 3-way collision — completes B-0451 substrate-hygiene sweep + +## PR description + +## Summary + +Fifth and **FINAL** per-collision cleanup from the [B-0451](docs/backlog/P1/B-0451-duplicate-row-id-substrate-cleanup-2026-05-13.md) sweep. Three rows shared `id: B-0409`: + +| Row | Filed | Scope | +|---|---|---| +| P1 wallet-immune-system | 2026-05-11 10:48 [#2709](https://github.com/Lucent-Financial-Group/Zeta/pull/2709) | Wallet immune system spec (L-effort) | +| P2 amara-persona-bootstrap | 2026-05-11 10:34 [#2704](https://github.com/Lucent-Financial-Group/Zeta/pull/2704) | B-0118 amara series atomic child | +| P2 peer-call-ts-audit | 2026-05-11 10:58 [#2706](https://github.com/Lucent-Financial-Group/Zeta/pull/2706) | B-0120 peer-call series atomic child | + +## Resolution: keep peer-call series at B-0409 + +Per external-references rule (canonical per [#3066](https://github.com/Lucent-Financial-Group/Zeta/pull/3066) procedure): + +- [B-0120 frontmatter](docs/backlog/P2/B-0120-peer-call-architecture-refactor-script-per-cli-persona-flag-2026-04-30.md) has `children: [B-0409, B-0410, B-0411, ...]` AND `depends_on: [B-0409, B-0410, ...]` — strongest references +- B-0118 has body-text mentions only (editable here) +- Wallet-immune-system has no incoming refs from other rows (composes_with B-0294/B-0321 point FROM the wallet row, not TO it) + +→ Keep peer-call B-0409. Renumber others to **B-0462 + B-0463** (bumped past PR #3070's B-0459/0460/0461 reservation for B-0449 slice 5+): + +``` +amara-persona-bootstrap B-0409 → B-0462 (completes amara series — B-0410 → B-0457, B-0411 → B-0458 already in PR #3069) +wallet-immune-system B-0409 → B-0463 +``` + +## Chain remap + +[#3069](https://github.com/Lucent-Financial-Group/Zeta/pull/3069) left `B-0457.depends_on: [B-0409]` pointing at the soon-to-be-renumbered amara B-0409. This PR remaps it to `[B-0462]` (and updates the body-text reference per Codex+Copilot round-1 catch). + +B-0118 parent body §Decomposition section updated to point at new IDs. + +## Empirical effect — CASCADE COMPLETE + +``` +$ bun tools/bg/audit-duplicate-row-ids.ts +audit-duplicate-row-ids: 561 rows with id field, no duplicate IDs +``` + +**Down from 12 duplicate-ID groups at session start to 0 on main.** + +[B-0451](docs/backlog/P1/B-0451-duplicate-row-id-substrate-cleanup-2026-05-13.md) cleanup progress: **11/12 → 12/12 — sweep complete.** + +## Session-arc cascade rounds + +| Round | PR | What | Groups | +|---|---|---|---| +| 1 | [#3053](https://github.com/Lucent-Financial-Group/Zeta/pull/3053) | B-0444 P1+P2 | 12 → 11 | +| 2 | [#3057](https://github.com/Lucent-Financial-Group/Zeta/pull/3057) | B-0068.1 | 11 → 10 | +| 3 | [#3058](https://github.com/Lucent-Financial-Group/Zeta/pull/3058) | B-0090.1-4 batch | 10 → 6 | +| 4 | [#3065](https://github.com/Lucent-Financial-Group/Zeta/pull/3065) | B-0370-0373 P2 batch | 6 → 3 | +| 5 | [#3069](https://github.com/Lucent-Financial-Group/Zeta/pull/3069) | B-0410-B-0411 amara batch | 3 → 1 | +| **6** | **(this PR)** | **B-0409 3-way (final) → B-0462/B-0463** | **1 → 0** | + +## Round-1 reviewer catch already addressed + +Initial commit on this branch picked B-0459/B-0460 (next-free at the time). PR #3070 then merged and reserved B-0459/0460/0461 for B-0449. Bumped to B-0462/B-0463 in commit `13f285f`. Tick shards in this PR document both the initial plan and the bump. + +🤖 Generated with [Claude Code](https://claude.com/claude-code) + +## Reviews + +### COMMENTED — @chatgpt-codex-connector (2026-05-14T00:22:59Z) + + +### 💡 Codex Review + +Here are some automated review suggestions for this pull request. + +**Reviewed commit:** `cc20e7c95b` + + +
ℹ️ About Codex in GitHub +
+ +[Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you +- Open a pull request for review +- Mark a draft as ready +- Comment "@codex review". + +If Codex has suggestions, it will comment; otherwise it will react with 👍. + + +Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". + +
+ +### COMMENTED — @copilot-pull-request-reviewer (2026-05-14T00:23:40Z) + +## Pull request overview + +Resolves the final `B-0451` duplicate backlog-row ID collision by ensuring `id: B-0409` is uniquely owned by the peer-call series row (B-0120 child), and renumbering the other two colliding rows to new IDs while updating cross-references and the generated backlog index. + +**Changes:** +- Renumbered the B-0118 child “amara persona bootstrap” from `B-0409` → `B-0459` and recorded renumber provenance in frontmatter. +- Renumbered the wallet immune system row from `B-0409` → `B-0460` and recorded renumber provenance in frontmatter. +- Updated dependent references (e.g., B-0457 `depends_on`) and regenerated `docs/BACKLOG.md` to reflect the new IDs. + +### Reviewed changes + +Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment. + +
+Show a summary per file + +| File | Description | +| ---- | ----------- | +| docs/backlog/P2/B-0459-amara-persona-bootstrap-preamble-definition-ts-first-riven-2026-05-11.md | Updates `id` to `B-0459` and adds renumber provenance metadata. | +| docs/backlog/P2/B-0457-amara-ts-core-openai-api-invoke-flag-parity-ts-first-riven-2026-05-11.md | Remaps `depends_on`/`composes_with` to the renumbered preamble row (`B-0459`). | +| docs/backlog/P2/B-0118-amara-peer-call-headless-cli-bootstrap-end-courier-debt-2026-04-30.md | Updates decomposition section to reference `B-0459` and the new child set. | +| docs/backlog/P1/B-0460-wallet-immune-system-vaccine-spread-poucc-spec.md | Updates `id` to `B-0460`, adds `last_updated`, and records renumber provenance metadata. | +| docs/BACKLOG.md | Regenerates index entries to remove old `B-0409` links and add `B-0460`/`B-0459`. | +
+ +### COMMENTED — @chatgpt-codex-connector (2026-05-14T00:29:00Z) + + +### 💡 Codex Review + +Here are some automated review suggestions for this pull request. + +**Reviewed commit:** `13f285fd59` + + +
ℹ️ About Codex in GitHub +
+ +[Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you +- Open a pull request for review +- Mark a draft as ready +- Comment "@codex review". + +If Codex has suggestions, it will comment; otherwise it will react with 👍. + + +Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". + +
+ +### COMMENTED — @AceHack (2026-05-14T00:29:06Z) + +_(no body)_ + +### COMMENTED — @AceHack (2026-05-14T00:29:10Z) + +_(no body)_ + +### COMMENTED — @copilot-pull-request-reviewer (2026-05-14T00:30:54Z) + +## Pull request overview + +Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments. + +### COMMENTED — @copilot-pull-request-reviewer (2026-05-14T00:41:59Z) + +## Pull request overview + +Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments. + + +
+Comments suppressed due to low confidence (1) + +**docs/backlog/P1/B-0463-wallet-immune-system-vaccine-spread-poucc-spec.md:14** +* The `renumbered_reason` states there were "No incoming references to wallet-immune-B-0409 from other rows" (beyond composes_with B-0294/B-0321), but there are still backlog rows that reference `B-0409` (e.g., `docs/backlog/P2/B-0413-...` and `docs/backlog/P2/B-0414-...` both have `composes_with: [B-0409]`). After this renumber, those references now resolve to the peer-call audit row, which is likely incorrect. Please either update those referencing rows to point at `B-0463` (if they meant the wallet row) and/or adjust this claim so it stays accurate. +
+ +## Review threads + +### Thread 1: docs/backlog/P2/B-0457-amara-ts-core-openai-api-invoke-flag-parity-ts-first-riven-2026-05-11.md:13 (resolved) + +**@chatgpt-codex-connector** (2026-05-14T00:22:59Z): + +**![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat) Align renumbered dependency with task narrative references** + +This row now depends on `B-0459`, but the task text still instructs implementers to use `B-0409` as the preamble source; after this renumbering, `B-0409` is a different peer-call audit item, so following the current instructions can pull the wrong artifact and break the B-0118 child-chain intent. Please update the in-body/evidence references in this file to `B-0459` so metadata and execution guidance stay consistent. + +Useful? React with 👍 / 👎. + +**@AceHack** (2026-05-14T00:29:05Z): + +Fixed in commit `13f285fd`: body references updated to `B-0462` (renumbered from B-0409 per B-0451 sweep). Both the prose and Evidence section are now consistent with the frontmatter `depends_on: [B-0462]`. + +### Thread 2: docs/backlog/P2/B-0457-amara-ts-core-openai-api-invoke-flag-parity-ts-first-riven-2026-05-11.md:13 (resolved) + +**@copilot-pull-request-reviewer** (2026-05-14T00:23:40Z): + +The body text in this row still refers to the preamble coming from `B-0409` (and the Evidence section lists `B-0118 + B-0409`), but this PR renumbers that preamble row to `B-0459` and updates `depends_on`/`composes_with` accordingly. Please update the remaining in-body references so the row stays self-consistent and doesn’t send readers to the wrong backlog ID. + +**@AceHack** (2026-05-14T00:29:10Z): + +Fixed in commit `13f285fd`: body references updated to `B-0462` (renumbered from B-0409 per B-0451 sweep). Both the prose and Evidence section are now consistent with the frontmatter `depends_on: [B-0462]`. + +### Thread 3: docs/hygiene-history/ticks/2026/05/14/0223Z.md:36 (resolved) + +**@chatgpt-codex-connector** (2026-05-14T00:29:00Z): + +**![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat) Correct stale renumber IDs in the tick history shard** + +This shard still records `B-0409 -> B-0459` / `B-0460` and a `B-0457.depends_on -> B-0459` remap, but this same commit actually renumbers the rows to `B-0462` and `B-0463` and updates `B-0457` to depend on `B-0462`. Leaving the old IDs in a durable hygiene-history artifact makes the cleanup provenance internally inconsistent and can mislead later audits or follow-on renumber work that uses tick shards as source-of-truth evidence. + +Useful? React with 👍 / 👎. + +### Thread 4: docs/hygiene-history/ticks/2026/05/14/0223Z.md:46 (resolved) + +**@copilot-pull-request-reviewer** (2026-05-14T00:30:53Z): + +Tick 0223Z describes the renumber as B-0459/B-0460 and the chain remap as B-0457.depends_on → B-0459, but this PR’s actual renumber/remap is to B-0462/B-0463 (see the updated backlog rows and the later 0238Z tick). Please update this tick shard to either reflect the final IDs/remap, or explicitly mark the B-0459/B-0460 plan as superseded (and point at Tick 0238Z) so the hygiene-history record doesn’t misstate what PR 3073 does. + +### Thread 5: docs/hygiene-history/ticks/2026/05/14/0238Z.md:28 (resolved) + +**@copilot-pull-request-reviewer** (2026-05-14T00:30:53Z): + +The PR description (and earlier 0223Z tick shard) still references the intermediate renumber targets B-0459/B-0460, but the branch was bumped again to B-0462/B-0463 to avoid the PR-3070 reserved range. Please update the PR description to match the final IDs to prevent reviewers/readers from following the wrong remap instructions. + +## General comments + +### @chatgpt-codex-connector (2026-05-14T00:28:16Z) + +You have reached your Codex usage limits for code reviews. You can see your limits in the [Codex usage dashboard](https://chatgpt.com/codex/cloud/settings/usage).